From owner-cvs-all@FreeBSD.ORG Wed Sep 27 22:46:20 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB20116A4D2; Wed, 27 Sep 2006 22:46:20 +0000 (UTC) (envelope-from sanewo@ba2.so-net.ne.jp) Received: from mx10.ms.so-net.ne.jp (mx10.ms.so-net.ne.jp [202.238.82.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA47643D82; Wed, 27 Sep 2006 22:45:32 +0000 (GMT) (envelope-from sanewo@ba2.so-net.ne.jp) Received: from [127.0.0.1] (p62a1f6.tkyoac00.ap.so-net.ne.jp [219.98.161.246]) by mx10.ms.so-net.ne.jp with ESMTP id k8RMikFx022144; Thu, 28 Sep 2006 07:44:55 +0900 (JST) Message-ID: <451AFEDE.7020607@ba2.so-net.ne.jp> Date: Thu, 28 Sep 2006 07:44:46 +0900 From: SANETO Takanori User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <200609130838.k8D8cnW9063228@repoman.freebsd.org> <4519DD53.8010005@ba2.so-net.ne.jp> <86wt7ppx16.fsf@dwp.des.no> <86odt1pww0.fsf@dwp.des.no> <451AFAFD.6050700@ba2.so-net.ne.jp> In-Reply-To: <451AFAFD.6050700@ba2.so-net.ne.jp> X-Enigmail-Version: 0.93.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d mountcritlocal mountlate src/sbin/mount mount.8 mount.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2006 22:46:20 -0000 I understand that the code around invoking external mount commands is quite different between -CURRENT and RELENG_6. I did not looked into the code but just saw commit message like "Do not pass noauto to nmount() or external mount program." in 1.73. What I actually did to avoid the error message I got was: > Index: mount.c > =================================================================== > RCS file: /export/cvs/src/sbin/mount/mount.c,v > retrieving revision 1.69.2.2 > diff -u -r1.69.2.2 mount.c > --- mount.c 13 Sep 2006 08:38:49 -0000 1.69.2.2 > +++ mount.c 26 Sep 2006 09:17:25 -0000 > @@ -429,6 +429,7 @@ > } > } > optbuf = catopt(strdup(mntopts), options); > + remopt(optbuf, "late"); > > if (strcmp(name, "/") == 0) > flags |= MNT_UPDATE; Can this be the correct fix for RELENG_6? Regards, Saneto SANETO Takanori wrote: > DES, > > I think it affects argv for external mount commands as well as nmount. > In fact, on RELENG_6, I got a message like "mount_smbfs: unknown option > -o late" when I put "late" in my fstab like this: > > //SANEWO@SMBHOST/SMBDRIVE /smb/mnt1 smbfs rw,late 0 0 > > Thanks, > > Saneto > > Dag-Erling Smørgrav wrote: >> des@des.no (Dag-Erling Smørgrav) writes: >>> SANETO Takanori writes: >>>> As for mount.c, following part should be MFC'ed as well. >>> Thanks, I don't understand how it was left out. >> Uh, wait, it was left out for a reason: there is no equivalent code in >> RELENG_6. The hunk in question removes "late" from the list of >> options passed to nmount(), which isn't used in RELENG_6. >> >> DES