From owner-freebsd-bugs@FreeBSD.ORG Sat Mar 15 01:20:04 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F7791065670 for ; Sat, 15 Mar 2008 01:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EE3EB8FC16 for ; Sat, 15 Mar 2008 01:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2F1K3EQ076052 for ; Sat, 15 Mar 2008 01:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2F1K3tI076051; Sat, 15 Mar 2008 01:20:03 GMT (envelope-from gnats) Date: Sat, 15 Mar 2008 01:20:03 GMT Message-Id: <200803150120.m2F1K3tI076051@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: bruce@cran.org.uk Cc: Subject: Re: bin/71613: [PATCH] traceroute(8): cleanup of the usr.sbin/traceroute6 code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bruce@cran.org.uk List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Mar 2008 01:20:04 -0000 The following reply was made to PR bin/71613; it has been noted by GNATS. From: bruce@cran.org.uk To: bug-followup@freebsd.org Cc: dan@obluda.cz Subject: Re: bin/71613: [PATCH] traceroute(8): cleanup of the usr.sbin/traceroute6 code Date: Sat, 15 Mar 2008 01:15:44 +0000 --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I'm not sure 'volatile' is correct in this case - string literals should be defined 'const' since they can't be changed. Doing this removes the warning about 'copyright' being unused. I've attached an updated patch. -- Bruce --4Ckj6UjgE2iN1+kY Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="traceroute6.c.diff" --- traceroute6.c.old 2008-03-15 01:07:03.000000000 +0000 +++ traceroute6.c 2008-03-15 01:07:36.000000000 +0000 @@ -66,7 +66,7 @@ */ #ifndef lint -static char copyright[] = +static const char copyright[] = "@(#) Copyright (c) 1990, 1993\n\ The Regents of the University of California. All rights reserved.\n"; #endif /* not lint */ --4Ckj6UjgE2iN1+kY--