From owner-cvs-all@FreeBSD.ORG Wed Oct 29 09:55:00 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71A0516A4CE; Wed, 29 Oct 2003 09:55:00 -0800 (PST) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id C007143FDD; Wed, 29 Oct 2003 09:54:58 -0800 (PST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h9THst439134; Wed, 29 Oct 2003 12:54:55 -0500 (EST) (envelope-from jroberson@chesapeake.net) Date: Wed, 29 Oct 2003 12:54:55 -0500 (EST) From: Jeff Roberson To: Bruce Evans In-Reply-To: <200310291440.h9TEef06021690@repoman.freebsd.org> Message-ID: <20031029125403.U43805-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_fork.c sched_4bsd.c sched_ule.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2003 17:55:00 -0000 On Wed, 29 Oct 2003, Bruce Evans wrote: > bde 2003/10/29 06:40:41 PST > > FreeBSD src repository > > Modified files: > sys/kern kern_fork.c sched_4bsd.c sched_ule.c > Log: > Removed sched_nest variable in sched_switch(). Context switches always > begin with sched_lock held but not recursed, so this variable was > always 0. Thanks. I still intend to comment on our earlier exchange on this. Mail backlog and all.. Cheers, Jeff > > Removed fixup of sched_lock.mtx_recurse after context switches in > sched_switch(). Context switches always end with this variable in the > same state that it began in, so there is no need to fix it up. Only > sched_lock.mtx_lock really needs a fixup. > > Replaced fixup of sched_lock.mtx_recurse in fork_exit() by an assertion > that sched_lock is owned and not recursed after it is fixed up. This > assertion much match the one in mi_switch(), and if sched_lock were > recursed then a non-null fixup of sched_lock.mtx_recurse would probably > be needed again, unlike in sched_switch(), since fork_exit() doesn't > return to its caller in the normal way. > > Revision Changes Path > 1.207 +1 -1 src/sys/kern/kern_fork.c > 1.26 +0 -3 src/sys/kern/sched_4bsd.c > 1.69 +0 -3 src/sys/kern/sched_ule.c >