From nobody Thu Nov 16 13:21:53 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SWLKc5Yrcz50fhQ; Thu, 16 Nov 2023 13:21:56 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SWLKc3XF1z4kYC; Thu, 16 Nov 2023 13:21:56 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6ce37683cf6so418257a34.3; Thu, 16 Nov 2023 05:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700140914; x=1700745714; darn=freebsd.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=84Z0dE+P9AXOaROUAZypHkMJkhVxKWs8enOBPQ2E/ug=; b=VYxxBfjhUUOGf1ijZK79VWoJCrzugqVEUtGkanTaR8ncASfEJ988T/bRr1f+4zLG98 67tzpfnqhdlB9lLMPUgSvSFHVhr86KGBjOqoGSUGKdfPsVhk26qC4xa+V1jfIm2ruxLm OJOlBJCOfwLgy0y0UU/uFo6XfhxmSjSNvYEiM/XQ2ru0PoX2YDSVdfKDiW0d0p59W3lz 4numWs9ufs9u3RLbglm8Q9hYVla6GLTMSFM3RrUVQp5wTm2EpNSTsDwHjY20INV31Tcp JeID5Q9lItFnX17AgTHMzArxbxUSPOGikECeep3tMyAgqAQywox0Jje/6ooscZ/DohOv oIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700140914; x=1700745714; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=84Z0dE+P9AXOaROUAZypHkMJkhVxKWs8enOBPQ2E/ug=; b=e9qbO6ivTrVOjVlI9m3bYtPcb38o3RRAcy/SW5bmFCu5ECUDXXyhsdkhkP0sn9/ejR cWPJXeN4ryg3pPGfYY9qjXzS8/HE2sFrTfklZ3kYl3HJLDpxF7pGjO0OfdlhhdxHiP6m 8G42iskoTpg5Oli8FEmVZPHVSm/xPrcqTluzOG4ht1BWOaLrNa48wcu/ThyPuVc5THsO bViX1kcarLeYJazoaKDZxMNsQhGo3XfDhlatqyprTPsEz7fj9N9tp+FSR+w9WRrOBEoh Q9LPm4I5hFI/60eDaAQ7WXMG6w4UNgdQvmD3RuOU1kz2wWL3YDDVo5QmKfKcyG8ELaiV AdRA== X-Gm-Message-State: AOJu0YypHcfeTLhIemDdqlzyx8VXRu7QalNU19Idgu2DKEiiPx4UX+W4 JOMi6cEPI3wtKfcLKmjzw7TSA4byxoUF/mvKurARlCgN X-Google-Smtp-Source: AGHT+IFI2A9tF3oSSChBEbe1ZdwNdRftrYiiJhqnocByS8mUHlmMyeYQeWEv7P9HwGjfkA1wVa3k/ZxzV/4g6ZaSTEY= X-Received: by 2002:a05:6830:410a:b0:6be:c1b:ded4 with SMTP id w10-20020a056830410a00b006be0c1bded4mr13665993ott.3.1700140914064; Thu, 16 Nov 2023 05:21:54 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Received: by 2002:a8a:c5:0:b0:4f0:1250:dd51 with HTTP; Thu, 16 Nov 2023 05:21:53 -0800 (PST) In-Reply-To: <202311161000.3AGA0Cxc058517@gitrepo.freebsd.org> References: <202311161000.3AGA0Cxc058517@gitrepo.freebsd.org> From: Mateusz Guzik Date: Thu, 16 Nov 2023 14:21:53 +0100 Message-ID: Subject: Re: git: a6ed8c959303 - main - Fix /root permissions after 'make installworld' To: Gordon Bergling Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4SWLKc3XF1z4kYC On 11/16/23, Gordon Bergling wrote: > The branch main has been updated by gbe: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=a6ed8c9593031abf6fa73661be55c226caa362d6 > > commit a6ed8c9593031abf6fa73661be55c226caa362d6 > Author: Thomas Eberhardt > AuthorDate: 2023-11-16 09:59:38 +0000 > Commit: Gordon Bergling > CommitDate: 2023-11-16 09:59:38 +0000 > > Fix /root permissions after 'make installworld' > > According to /etc/mtree/BSD.root.dist /root should have > 0750 permissions, but the build target 'make installworld' > changes these to 0755. > > This is caused by the installation of the configuration > files of sh(1) and csh(1). > > Correct this by specifying the correct default /root permissions. > > PR: 273342 > Reviewed by: jilles > Approved by: jilles > MFC after: 2 weeks > Differential Revision:https://reviews.freebsd.org/D42395 > --- > bin/csh/Makefile | 1 + > bin/sh/Makefile | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/bin/csh/Makefile b/bin/csh/Makefile > index 1f996df3999b..94e1ba763d6e 100644 > --- a/bin/csh/Makefile > +++ b/bin/csh/Makefile > @@ -15,6 +15,7 @@ ROOTPACKAGE= csh > ETC= csh.cshrc csh.login csh.logout > ROOT= dot.cshrc dot.login > ROOTDIR= /root > +ROOTDIR_MODE= 0750 This is at best a total workaround, the real bug is that root dir gets modified to begin with and there will be other cases prone to cause the same problem. More importantly, is not this a regression from security pov? -- Mateusz Guzik