From owner-cvs-all@FreeBSD.ORG Wed May 26 18:50:23 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CC1C16A4CE; Wed, 26 May 2004 18:50:23 -0700 (PDT) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC09043D45; Wed, 26 May 2004 18:50:22 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i4R1nu5v011151; Thu, 27 May 2004 11:49:56 +1000 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i4R1nr2O026090; Thu, 27 May 2004 11:49:54 +1000 Date: Thu, 27 May 2004 11:49:48 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: John Baldwin In-Reply-To: <200405261032.49453.jhb@FreeBSD.org> Message-ID: <20040527114013.X8390@gamplex.bde.org> References: <200405260743.i4Q7hg3t059231@repoman.freebsd.org> <200405261032.49453.jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Bruce Evans cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files.i386 src/sys/i386/i386apic_vector.s exception.s src/sys/i386/isa atpic_vector.s X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2004 01:50:23 -0000 On Wed, 26 May 2004, John Baldwin wrote: > On Wednesday 26 May 2004 03:43 am, Bruce Evans wrote: > > bde 2004/05/26 00:43:41 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files.i386 > > sys/i386/i386 apic_vector.s exception.s > > sys/i386/isa atpic_vector.s > > Log: > > MFamd64: > > > > Fixed profiling of trap, syscall and interrupt handlers and some > > ordinary functions, essentially by backing out half of rev.1.106 of > > i386/exception.s. The handlers must be between certain labels for > > the purposes of profiling, and this was broken by scattering them in > > separately compiled .s files, especially for ordinary functions that > > ended up between the labels. Merge the files by #including them as > > before, except with different pathnames and better comments and > > organization. Changes to the scattered files are minimal -- just > > move the labels to the file that does the #includes. > > Oh well, there will never be an apic.ko then. Including files shouldn't affect modules, since they are only included when the option is only configured as a module. apic.ko would just not work right with profiling, the same as now. To work right, it would somehow have to arrange that its symbols are correctly classified by mcount(), perhaps by putting them in a special subsection of the text section. Does kldload(2) support this? I can't see where it reads ldscript.${MACHINE}. Bruce