From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jan 19 22:10:11 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7A8A1065695 for ; Wed, 19 Jan 2011 22:10:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8D23F8FC15 for ; Wed, 19 Jan 2011 22:10:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0JMAB3U014374 for ; Wed, 19 Jan 2011 22:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0JMABpP014373; Wed, 19 Jan 2011 22:10:11 GMT (envelope-from gnats) Resent-Date: Wed, 19 Jan 2011 22:10:11 GMT Resent-Message-Id: <201101192210.p0JMABpP014373@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Steven Kreuzer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B489106566C; Wed, 19 Jan 2011 22:03:24 +0000 (UTC) (envelope-from skreuzer@exit2shell.com) Received: from exit2shell.com (64.147.119.38.static.nyinternet.net [64.147.119.38]) by mx1.freebsd.org (Postfix) with ESMTP id CADF88FC15; Wed, 19 Jan 2011 22:03:23 +0000 (UTC) Received: by exit2shell.com with ESMTP id p0JLVqga088249; Wed, 19 Jan 2011 16:31:52 -0500 (EST) Received: (from skreuzer@localhost) by exit2shell.com (8.14.3/8.14.4/Submit) id p0JLVqZc088248; Wed, 19 Jan 2011 16:31:52 -0500 (EST) (envelope-from skreuzer) Message-Id: <201101192131.p0JLVqZc088248@exit2shell.com> Date: Wed, 19 Jan 2011 16:31:52 -0500 (EST) From: Steven Kreuzer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: marcus@FreeBSD.org Subject: ports/154149: [PATCH] ports-mgmt/portlint: Complain when not using dist/ with CPAN X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2011 22:10:11 -0000 >Number: 154149 >Category: ports >Synopsis: [PATCH] ports-mgmt/portlint: Complain when not using dist/ with CPAN >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jan 19 22:10:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Steven Kreuzer >Release: FreeBSD 7.3-PRERELEASE amd64 >Organization: >Environment: System: FreeBSD slurry.exit2shell.com 7.3-PRERELEASE FreeBSD 7.3-PRERELEASE #4: Wed Mar 3 11:32:49 EST >Description: In pkg-descr, have portlint warn if WWW is equal to something like http://search.cpan.org/~miyagawa/TheSchwartz-Simple-0.05/ and suggest that it gets changed to http://search.cpan.org/dist/TheSchwartz-Simple/ Port maintainer (marcus@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: >Fix: --- portlint-2.13.3_1.patch begins here --- Index: Makefile =================================================================== RCS file: /usr/share/cvs/freebsd/ports/ports-mgmt/portlint/Makefile,v retrieving revision 1.140 diff -u -u -r1.140 Makefile --- Makefile 10 Jan 2011 04:43:58 -0000 1.140 +++ Makefile 19 Jan 2011 21:26:55 -0000 @@ -9,6 +9,7 @@ PORTNAME= portlint PORTVERSION= 2.13.3 +PORTREVISION= 1 CATEGORIES= ports-mgmt MASTER_SITES= # none DISTFILES= # none Index: src/portlint.pl =================================================================== RCS file: /usr/share/cvs/freebsd/ports/ports-mgmt/portlint/src/portlint.pl,v retrieving revision 1.118 diff -u -u -r1.118 portlint.pl --- src/portlint.pl 10 Jan 2011 04:43:58 -0000 1.118 +++ src/portlint.pl 19 Jan 2011 21:27:54 -0000 @@ -636,6 +636,10 @@ &perror("WARN", $file, -1, "WWW URL, $wwwurl should begin ". "with \"http://\" or \"https://\"."); } + if ($wwwurl =~ m|^http://search.cpan.org/~|) { + &perror("WARN", $file, -1, "consider changing WWW URL to " . + "http://search.cpan.org/dist/$makevar{PORTNAME}"); + } } $linecnt++; $longlines++ if ($maxchars{$file} < length); --- portlint-2.13.3_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: