Date: Fri, 08 Jul 2016 01:34:04 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210876] multimedia/assimp: Update to 3.3 Message-ID: <bug-210876-13-DYIZUDcIYg@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-210876-13@https.bugs.freebsd.org/bugzilla/> References: <bug-210876-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210876 lightside <lightside@gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yuri@rawbw.com Attachment #172218| |maintainer-approval?(yuri@r Flags| |awbw.com) --- Comment #3 from lightside <lightside@gmx.com> --- Created attachment 172218 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172218&action= =3Dedit Proposed patch (since 416829 revision) Hello Yuri Victorovich and Kurt Jaeger. I noticed this PR recently and analyzed changes for v3.3 release tag: https://github.com/assimp/assimp/releases/tag/v3.3 https://github.com/assimp/assimp/compare/v3.2...v3.3 I found, that developers didn't (or forgot to) change ASSIMP_VERSION_MINOR = from 2 to 3: https://github.com/assimp/assimp/blob/19769eef8b9612a82fdb55c245db871476e7f= 178/CMakeLists.txt#L49 while they changed value of MinorVersion variable to 3: https://github.com/assimp/assimp/commit/19769eef8b9612a82fdb55c245db871476e= 7f178 Because of this, I propose to use GH_TAGNAME, in case of possible re-tag: https://github.com/assimp/assimp/compare/v3.2...19769ee The patch in attachment #172181 contains changes for files/patch-include_assimp_Compiler_pstdint.h file, which updates include/assimp/Compiler/pstdint.h file from 0.1.12 (in sources) to 0.1.15.4 version. Looks like, the patch changes whole file, instead of concrete line= s. Therefore, I propose patch, which created by `make makepatch` command, but = with some changes "to remove comments with private information". The 0.1.12 vers= ion (with custom changes, based on private information and strange wording in comments) was proposed by afiskon, for reference: https://github.com/assimp/assimp/issues/795 Also, I think (and tested this), this version doesn't require devel/boost-l= ibs library dependency and BOOST option, while there are some traces of "boost" words in sources, but no ASSIMP_ENABLE_BOOST_WORKAROUND cmake's option, as = it was before 3.3 version. It requires C++11 features: https://github.com/assimp/assimp/blob/19769eef8b9612a82fdb55c245db871476e7f= 178/CMakeLists.txt#L117 which may require to add compiler:c++11-lang to USES. The proposed patch attached, with following changes (including maintainer's changes): - Use GH_TAGNAME for current version - Remove BOOST option and add compiler:c++11-lang to USES - Add sed patch to change ASSIMP_VERSION_MINOR from 2 to 3 for CMakeLists.t= xt file - Add patch for code/BlenderTessellator.cpp file - Adapt patch for include/assimp/Compiler/pstdint.h file - Adapt pkg-plist --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210876-13-DYIZUDcIYg>