From owner-freebsd-net@FreeBSD.ORG Wed Jul 4 00:21:35 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 48A5F16A41F for ; Wed, 4 Jul 2007 00:21:35 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.180]) by mx1.freebsd.org (Postfix) with ESMTP id C9C1E13C43E for ; Wed, 4 Jul 2007 00:21:34 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id j37so3011548waf for ; Tue, 03 Jul 2007 17:21:34 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=VAqn/gMC4c14BghyvlvLfZGy7T6ZY/ff4BbLpwqWgq6TbqDYwRvIGkIBdSldUs0T5NS53AuSJnYVUE90xAUiBO2/b2bkJhp0e8ceAe05/NmhuJHOhvMIJxLM7lfzkKLig0nMsZrBgObR71dxqcr7qbw0ji/Exf8fIJADIatEHcE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Ne8UpKl3h7EAEOdFWeN04j4pjvpTCdiOLP3KoBD/uCLkqErPzF1AK/sf//YPsOVMCohIQTTOsoEwaUvs+pyiCFOOMVXpQ49hP6M0zOELSsxYqq4vN1Rxzx3HwOGRYutJ3G2Nq+I+BNvC1Npei29fqKwCFlCnSTWx2mdGLTQQng8= Received: by 10.115.33.1 with SMTP id l1mr6725330waj.1183508494362; Tue, 03 Jul 2007 17:21:34 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id j38sm1638597waf.2007.07.03.17.21.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Jul 2007 17:21:33 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l640LSE8072666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 Jul 2007 09:21:28 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l640LRE5072665; Wed, 4 Jul 2007 09:21:27 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Wed, 4 Jul 2007 09:21:27 +0900 From: Pyun YongHyeon To: W Forms , freebsd-net@FreeBSD.org Message-ID: <20070704002127.GA72486@cdnetworks.co.kr> References: <200707031100.l63B0GV0020511@freefall.freebsd.org> <20070703152706.GA32357@verio.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070703152706.GA32357@verio.net> User-Agent: Mutt/1.4.2.1i Cc: Subject: Re: kern/112710: [re] if_re driver detects incorrect b243a405a405 MAC address on SMC9452TX-1 pci gigabit cards X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2007 00:21:35 -0000 On Tue, Jul 03, 2007 at 10:27:07AM -0500, David DeSimone wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > W Forms wrote: > > > > I don't really understand this, since from what I can see all that > > Pyun YongHyeon's changes do is replacing a constant value of 6 and 8 > > with macros containing the value of 6 and 8. > > Here's the patch as I recall it: > > > - sc->rl_eewidth = 6; > + sc->rl_eewidth = RL_9356_ADDR_LEN; > re_read_eeprom(sc, (caddr_t)&re_did, 0, 1); > if (re_did != 0x8129) > - sc->rl_eewidth = 8; > + sc->rl_eewidth = RL_9346_ADDR_LEN; > > /* 9346 EEPROM commands */ > +#define RL_9346_ADDR_LEN 6 /* 93C46 1K: 128x16 */ > +#define RL_9356_ADDR_LEN 8 /* 93C56 2K: 256x16 */ > > It looks to me like 6 was replaced with 8, and vice versa. In other > words, a real bug fix. :) > Yep. Previously it tried to probe 93C46 EEPROM first. Now it probes 93C56 before going back to 93C46. I'll ask for re approval to commit. Thanks for testing and report! -- Regards, Pyun YongHyeon