From nobody Fri Jun 5 06:02:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gWrSX0cVrz6gSwc for ; Fri, 05 Jun 2026 06:02:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gWrSW3LHSz3HGm for ; Fri, 05 Jun 2026 06:02:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780639355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dPs/fKiuu/R9fng0w4qjLXrfDhPTs0B3gMdOI9jYijU=; b=xhKJqAsWROec5tTqDtY7Bg+P/QWU8kmXAd9tq9IrMCYsUQohMlgMOTBVd2DjjCSwj7OWU0 XpT15eauEweOLyv4l+i5ib0kk6DfjX3RtYrt99EAy9f+1uQ7OlkMIr3HqWhhUBq3DH5h8P VzuL7M6YwV/BCXORhcizbn6dbWoRI/xMaLpMBpnwtbQAih8HtPNsa8Jp0T6LkyAEmosV5b cD5V1XG6A3Pbu3GUFhd1D+U2gso6FL3eWYeZqg7YID0wY92hb2gaY2d7F2ROWsrJoR1Utx bpD14RqZCFnFDBNKNJO+GAqyz613AER4ntoqeLP/dmK/xVz0oRQWA1usb0n+bA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780639355; a=rsa-sha256; cv=none; b=i5pqXBXrm3oKcoWNN6lSuYnhXuXMZlUmSCbCpMGkPwm0Fh9mZe7P83uFnNv2Qwi+fWdor+ jyeq4FVXISQ1fJgzG6vxFxSc4UCbVsdI3/pfG5s8KDwuR6rVvqdE+sVVgDTEHyp0OiKMjx RQb0Jvp5VC5lMuM2yp8nXOKKx2eCDONvWlO0qjH8V4wEwvMNCWjz9YFS5ZDA8NzQVsFX2A zgo/nYEr5p79qcDkHzm5Yr4pejX/04NPoTKmoJnLf9FKdrxal4Nn9dEdPEjotVxFl9u+XZ k0ksCgEd00o0Gq2AUySv6y9xAxY1iEdT8BbzsGMFRNH9N9oxJpnx9TtMIm+Jxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780639355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dPs/fKiuu/R9fng0w4qjLXrfDhPTs0B3gMdOI9jYijU=; b=kZ0N/6BLVV9d5nrNnF7VMI6sIGh95AFZ6gZshoWjcbsds0aje3V5Eovpgzi8a8s2sXOBsI fLYQHVHKL48pValSqKBOuYV4jJumQTAYCbsgAb5mZc5HZ+uP4tV9JETR1prRLd2sbvPbfU yTAn1iTlQ20ypmiJYediQQ1PeOywb4QfuGi4lVC6oj4fs3f9h1ytO7P8UgYMJI+3qfksIM AKXybApnVY2EOJl18CJjsoi9sVmsxU03VukgtfXQNePhXwsSORSJ4SmTWikZpu0gTtmnUL Xi9mTCRmyfh4Es0UNldmvj5x55cjmATyQrNAfE4+6KHBD8TaY3qNuYcXX/qYPg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gWrSW2yLCz1wZ for ; Fri, 05 Jun 2026 06:02:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 260ae by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 05 Jun 2026 06:02:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Baptiste Daroussin Subject: git: 13f4a37b536b - main - pw: fix uninitialized name pointer in pw_group_del List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 13f4a37b536b60d559c766b3ec4f2d5d25279ea3 Auto-Submitted: auto-generated Date: Fri, 05 Jun 2026 06:02:35 +0000 Message-Id: <6a22667b.260ae.79f19f43@gitrepo.freebsd.org> The branch main has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=13f4a37b536b60d559c766b3ec4f2d5d25279ea3 commit 13f4a37b536b60d559c766b3ec4f2d5d25279ea3 Author: Baptiste Daroussin AuthorDate: 2026-06-04 22:12:24 +0000 Commit: Baptiste Daroussin CommitDate: 2026-06-05 06:01:24 +0000 pw: fix uninitialized name pointer in pw_group_del The 'name' variable could be left uninitialized if neither the positional argument nor -n is supplied, leading to undefined behavior when passed to getgroup(). --- usr.sbin/pw/pw_group.c | 2 +- usr.sbin/pw/tests/pw_groupdel_test.sh | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/usr.sbin/pw/pw_group.c b/usr.sbin/pw/pw_group.c index 1941c03aa2c5..2840e972af59 100644 --- a/usr.sbin/pw/pw_group.c +++ b/usr.sbin/pw/pw_group.c @@ -367,7 +367,7 @@ pw_group_del(int argc, char **argv, char *arg1) { struct userconf *cnf = NULL; struct group *grp = NULL; - char *name; + char *name = NULL; const char *cfg = NULL; intmax_t id = -1; int ch, rc; diff --git a/usr.sbin/pw/tests/pw_groupdel_test.sh b/usr.sbin/pw/tests/pw_groupdel_test.sh index fa51b3814205..0fb5651944f3 100755 --- a/usr.sbin/pw/tests/pw_groupdel_test.sh +++ b/usr.sbin/pw/tests/pw_groupdel_test.sh @@ -18,6 +18,20 @@ group_do_not_delete_wheel_if_group_unknown_body() { } +atf_test_case group_delete_by_gid cleanup +group_delete_by_gid_head() { + atf_set "descr" "Test deleting a group by gid without providing a name" +} +group_delete_by_gid_body() { + populate_etc_skel + ${PW} groupadd testgroup -g 1000 || atf_fail "Creating test group" + atf_check -s exit:0 -o inline:"testgroup:*:1000:\n" \ + -x ${PW} groupshow 1000 + ${PW} groupdel -g 1000 || atf_fail "Deleting group by gid" +} + + atf_init_test_cases() { - atf_add_test_case group_do_not_delete_wheel_if_group_unknown + atf_add_test_case group_do_not_delete_wheel_if_group_unknown + atf_add_test_case group_delete_by_gid }