From owner-svn-ports-all@freebsd.org Tue Oct 6 05:01:20 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 015273FA7D3; Tue, 6 Oct 2020 05:01:20 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C550H4sPYz3g85; Tue, 6 Oct 2020 05:01:19 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 80EAE33E31; Tue, 6 Oct 2020 01:01:13 -0400 (EDT) Received: from [192.168.1.98] (athedsl-221241.home.otenet.gr [85.74.183.215]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 6079033E24; Tue, 6 Oct 2020 01:01:12 -0400 (EDT) Date: Tue, 6 Oct 2020 08:00:45 +0300 (EEST) From: Gerald Pfeifer To: Piotr Kubaj cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r551539 - head/devel/libffcall In-Reply-To: <202010051912.095JCL9k036435@repo.freebsd.org> Message-ID: References: <202010051912.095JCL9k036435@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4C550H4sPYz3g85 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 05:01:20 -0000 On Mon, 5 Oct 2020, Piotr Kubaj wrote: > Log: > devel/libffcall: fix build > > Submitted by: se@ > Reported by: linimon@ > > Modified: > head/devel/libffcall/Makefile > > Modified: head/devel/libffcall/Makefile > ============================================================================== > --- head/devel/libffcall/Makefile Mon Oct 5 19:11:21 2020 (r551538) > +++ head/devel/libffcall/Makefile Mon Oct 5 19:12:21 2020 (r551539) > @@ -19,6 +19,7 @@ BROKEN_mips64= fails to build: gmake[2]: No rule to m > > GNU_CONFIGURE= yes > USES= gmake libtool > +USE_GCC= yes What was the actual failure? I hope not an -fcommon issue, or this would actively block moving the default for USE_GCC from GCC 9 to GCC 10. When introducing USE_GCC these days, it would be good to note (in a comment or the commit message) why. Gerald