From owner-cvs-usrbin Mon Sep 29 05:47:09 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id FAA08310 for cvs-usrbin-outgoing; Mon, 29 Sep 1997 05:47:09 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id FAA08305; Mon, 29 Sep 1997 05:47:04 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id WAA01186; Mon, 29 Sep 1997 22:42:45 +1000 Date: Mon, 29 Sep 1997 22:42:45 +1000 From: Bruce Evans Message-Id: <199709291242.WAA01186@godzilla.zeta.org.au> To: bde@zeta.org.au, imp@village.org Subject: Re: cvs commit: src/usr.bin/make main.c var.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >: is already included by make.h which is included by almost >: everything (blech). > >Then I'm confused as to why I was getting warnings about getenv not >being defined on Digital Unix when I tried to compile make there >before I made the change... The #include of is protected by `#if __STDC__' and Digital Unix apparently doesn't support Standard C by default. Including unconditionally increases the breakage of support for nonstandard C. It has already been broken in rev.1.10 of main.c by removing the apparently-redundant nested extern declaration of getenv(). var.c has always been broken (getenv is not declared and doesn't return int). Bruce