From owner-freebsd-commit  Wed Apr  5 23:58:02 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id XAA12619
          for commit-outgoing; Wed, 5 Apr 1995 23:58:02 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id XAA12606
          for cvs-ports-outgoing; Wed, 5 Apr 1995 23:57:55 -0700
Received: from time.cdrom.com (time.cdrom.com [192.216.223.46])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA12600
          ; Wed, 5 Apr 1995 23:57:53 -0700
Received: from estienne.cs.berkeley.edu (estienne.CS.Berkeley.EDU [128.32.42.147]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id XAA10992; Wed, 5 Apr 1995 23:57:52 -0700
Received: from localhost (localhost [127.0.0.1]) by estienne.cs.berkeley.edu (8.6.11/8.6.9) with SMTP id XAA21894; Wed, 5 Apr 1995 23:55:31 -0700
Message-Id: <199504060655.XAA21894@estienne.cs.berkeley.edu>
X-Authentication-Warning: estienne.cs.berkeley.edu: Host localhost didn't use HELO protocol
To: Kai.Vorma@hut.fi
cc: "Jordan K. Hubbard" <jkh@freefall.cdrom.com>,
        "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>,
        jkh@freebsd.org (Jordan K. Hubbard), CVS-commiters@time.cdrom.com,
        cvs-ports@time.cdrom.com
Subject: Re: cvs commit: ports/net/sup/patches patch-ae 
In-reply-to: Your message of "Thu, 06 Apr 1995 09:44:40 +0300."
             <199504060644.JAA25387@vinkku.hut.fi> 
Date: Wed, 05 Apr 1995 23:55:30 -0700
From: "Justin T. Gibbs" <gibbs@estienne.cs.berkeley.edu>
Sender: commit-owner@freebsd.org
Precedence: bulk

>Jordan K. Hubbard writes:
>
> > 1. Sorry, I thought he'd changed the manpage.  I'll document it if he
> >    doesn't beat me to it.
>
>Do it, please. My english is far from perfect..
>
> > 2. You turn it off by not creating a file with the special name.. :-)
>
>Jup. I thought about adding some flag for it, but consider:
>
>1) a flag that turns it on?
>
>    You forget once that flag and all your local modifications are
>    gone :-(
>
>2) a flag that turns it off?
>
>   Why? Just rename all #sup files back to normal. Of course sup could
>   do that for you but I tried to keep it simple.

It also doesn't work when the "delete" option is turned on so it gives
you a false sense of security.  SUP will go ahead and delete the file
you're working on.

Please, just back this out for now.  The real way to implement this is to
piggy back it ontop of my "rename" option that i've had working and tested
for months at TCS.  I was just cleaning up the comments so I could submit
it when this stuff allstarted to happen.  The rename option takes care of 
all of the delete problems and you can simply write your feature as an 
extension to it (ie pretend that we are renaming the destination file to 
filename.#sup and the rest of the book keeping is handled automatically).

>
> > 3. You would prefer that he simply not admit to the hackery? ;-)
>
>:-) I admit the patch wasn't very pretty. Sup itself is quite a mess
>(much of nice globals and interesting code-paths etc.) so I just
>decided to make as few modifications as possible.
>
>..vode

--
Justin T. Gibbs
==============================================
TCS Instructional Group - Programmer/Analyst 1
  Cory | Po | Danube | Volga | Parker | Torus
==============================================