Date: Sat, 22 Sep 2007 15:25:02 -0700 (PDT) From: Doug Barton <dougb@FreeBSD.org> To: freebsd-rc@freebsd.org Subject: rc.d cleanup patch redux Message-ID: <alpine.BSF.0.9999.0709221521520.63456@qbhto.arg>
next in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 Ok, let's try this again. :-/ At the below URL is a patch that does the following: 1. Remove "Deprecated variable name support" from rc.subr that was supposed to be done after 6.x branched, but didn't get done (substantially my fault). 2. Remove $NetBSD$ tags from all the rc.d files, since they aren't really relevant any longer, and the information will be in CVS anyway. I'm leaving it in rc.subr since we still occasionally pull stuff over in that file. 3. Remove the comment from named_flags, to match all the other empty _flags variables *grumble* 4. s/bootparams/bootparamd/g to match the convention of having $name, PROVIDE, and file name match. I did check to make sure this script isn't called from anywhere else, but if anyone is actually using it that would be great feedback. 5. Add the shutdown KEYWORD to all the scripts that start persistent services. I'm not sure why this was never done in the past, but I think it should be done, since it allows the possibility of a clean(er) shutdown. I left out network, routing, and kerberos stuff from this pass, since I don't use kerberos and I'm not sure what effect this would have, and routing (including firewall stuff) can go down last as it does now. 6. cvs rm'ed bootconf.sh (it's not hooked up, and hasn't been for a long time) and removed early.sh (as previously advertised way back when). 7. A few miscellaneous whitespace cleanups. 8. Added a couple stop_cmd=':' where needed. In an ideal world, none of this should negatively impact functionality, especially at boot. I'm interested in feedback about the shutdown stuff though, and obviously the more testing the better ... Doug http://dougbarton.us/rcd-cleanup.patch - -- This .signature sanitized for your protection -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFG9ZY/yIakK9Wy8PsRA0ZgAKD0fKPbP8MRVYO1rlPqEtGl9BH9agCgnEj6 bqZKWo1JINJSHx8UAJykKY8= =luWr -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.0.9999.0709221521520.63456>