From owner-freebsd-bugs@FreeBSD.ORG  Fri Jul  4 14:30:12 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DD83337B4CA
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  4 Jul 2003 14:30:12 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 81D444400F
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  4 Jul 2003 14:30:11 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h64LUBUp099925
	for <freebsd-bugs@freefall.freebsd.org>;
	Fri, 4 Jul 2003 14:30:11 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h64LUBxH099924;
	Fri, 4 Jul 2003 14:30:11 -0700 (PDT)
Date: Fri, 4 Jul 2003 14:30:11 -0700 (PDT)
Message-Id: <200307042130.h64LUBxH099924@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Ruslan Ermilov <ru@FreeBSD.org>
Subject: Re: bin/54113: [PATCH] devd(8) doesn't write correct pid into
	/var/run/devd.pid
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Ruslan Ermilov <ru@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jul 2003 21:30:13 -0000

The following reply was made to PR bin/54113; it has been noted by GNATS.

From: Ruslan Ermilov <ru@FreeBSD.org>
To: Lukas Ertl <l.ertl@univie.ac.at>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/54113: [PATCH] devd(8) doesn't write correct pid into /var/run/devd.pid
Date: Sat, 5 Jul 2003 00:22:05 +0300

 A better fix might be:
 
 %%%
 Index: devd.cc
 ===================================================================
 RCS file: /home/ncvs/src/sbin/devd/devd.cc,v
 retrieving revision 1.14
 diff -u -p -r1.14 devd.cc
 --- devd.cc	2 May 2003 17:38:08 -0000	1.14
 +++ devd.cc	4 Jul 2003 21:18:19 -0000
 @@ -596,6 +596,7 @@ event_loop(void)
  				if (Dflag)
  					fprintf(stderr, "Calling daemon\n");
  				daemon(0, 0);
 +				cfg.drop_pidfile();
  				once++;
  			}
  		}
 @@ -743,9 +744,10 @@ main(int argc, char **argv)
  	}
  
  	cfg.parse();
 -	if (!dflag && nflag)
 +	if (!dflag && nflag) {
  		daemon(0, 0);
 -	cfg.drop_pidfile();
 +		cfg.drop_pidfile();
 +	}
  	signal(SIGHUP, gensighand);
  	signal(SIGINT, gensighand);
  	signal(SIGTERM, gensighand);
 %%%
 
 -- 
 Ruslan Ermilov		Sysadmin and DBA,
 ru@sunbay.com		Sunbay Software Ltd,
 ru@FreeBSD.org		FreeBSD committer