Date: Tue, 06 Jan 2015 13:08:02 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 194672] [carp] Changing advskew to 0 from another value doesn't work Message-ID: <bug-194672-2472-U743y0hTmt@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-194672-2472@https.bugs.freebsd.org/bugzilla/> References: <bug-194672-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194672 --- Comment #6 from commit-hook@freebsd.org --- A commit references this bug: Author: loos Date: Tue Jan 6 13:07:14 UTC 2015 New revision: 276751 URL: https://svnweb.freebsd.org/changeset/base/276751 Log: Remove the check that prevent carp(4) advskew to be set to '0'. CARP devices are created with advskew set to '0' and once you set it to any other value in the valid range (0..254) you can't set it back to zero. The code in question is also used to prevent that zeroed values overwrite the CARP defaults when a new CARP device is created. Since advskew already defaults to '0' for newly created devices and the new value is guaranteed to be within the valid range, it is safe to overwrite it here. PR: 194672 Reported by: cmb@pfsense.org In collaboration with: garga Tested by: garga MFC after: 2 weeks Changes: head/sys/netinet/ip_carp.c -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194672-2472-U743y0hTmt>