From owner-svn-src-head@FreeBSD.ORG Fri Feb 27 17:13:05 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E0CE1065686 for ; Fri, 27 Feb 2009 17:13:05 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outP.internet-mail-service.net (outp.internet-mail-service.net [216.240.47.239]) by mx1.freebsd.org (Postfix) with ESMTP id D7F778FC18 for ; Fri, 27 Feb 2009 17:13:04 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id 9E47B2C44; Fri, 27 Feb 2009 09:13:04 -0800 (PST) X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id F11212D605D; Fri, 27 Feb 2009 09:13:03 -0800 (PST) Message-ID: <49A81F1F.5070409@elischer.org> Date: Fri, 27 Feb 2009 09:13:03 -0800 From: Julian Elischer User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <200902271412.n1REC5JD072503@svn.freebsd.org> <20090227141248.E53478@maildrop.int.zabbadoz.net> In-Reply-To: <20090227141248.E53478@maildrop.int.zabbadoz.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189106 - in head/sys: compat/linprocfs compat/linux compat/svr4 contrib/altq/altq contrib/pf/net dev/cxgb/ulp/iw_cxgb kern net net80211 netgraph netgraph/atm netinet netinet6 netipsec ... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2009 17:13:06 -0000 Bjoern A. Zeeb wrote: > On Fri, 27 Feb 2009, Bjoern A. Zeeb wrote: > >> Author: bz >> Date: Fri Feb 27 14:12:05 2009 >> New Revision: 189106 >> URL: http://svn.freebsd.org/changeset/base/189106 >> >> Log: >> For all files including net/vnet.h directly include opt_route.h and >> net/route.h. >> >> Remove the hidden include of opt_route.h and net/route.h from >> net/vnet.h. >> >> We need to make sure that both opt_route.h and net/route.h are included >> before net/vnet.h because of the way MRT figures out the number of FIBs >> from the kernel option. If we do not, we end up with the default number >> of 1 when including net/vnet.h and array sizes are wrong. >> >> This does not change the list of files which depend on opt_route.h >> but we can identify them now more easily. > > and before anyone is going to start a bikeshed: > > - Yes it's the nth time things are shuffled around because of this. > > - I don't like it either. > > - The proper ordering is needed for the moment. > > - Another upcoming change would have tripped over this and broken > LINTs which have a non-default (1) number of ROUTETABLES=2. > > - People are thinking of a better solution for the > struct radix_node_head *_rt_tables[RT_MAXFIBS][AF_MAX+1]; > in net/vnet.h. in fact we need to change it SOON because if we change the ABI we need to do it in 8. > > > /bz > >