From owner-freebsd-stable Mon Oct 28 23: 9:19 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58E5A37B401; Mon, 28 Oct 2002 23:09:17 -0800 (PST) Received: from www.svzserv.kemerovo.su (www.svzserv.kemerovo.su [213.184.65.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11D5D43E4A; Mon, 28 Oct 2002 23:09:15 -0800 (PST) (envelope-from eugen@kuzbass.ru) Received: from kuzbass.ru (kost [213.184.65.82]) by www.svzserv.kemerovo.su (8.12.6/8.12.5) with ESMTP id g9T796Nf025802; Tue, 29 Oct 2002 14:09:08 +0700 (KRAT) (envelope-from eugen@kuzbass.ru) Message-ID: <3DBE25EF.AFDF596D@kuzbass.ru> Date: Tue, 29 Oct 2002 13:08:47 +0700 From: Eugene Grosbein Organization: SVZServ X-Mailer: Mozilla 4.79 [en] (Win95; U) X-Accept-Language: ru,en MIME-Version: 1.0 To: Maxim Konovalov Cc: stable@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_fw.c (fwd) References: <20021028154848.F68847-100000@news1.macomnet.ru> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Maxim Konovalov wrote: > > This is a direct commit to -STABLE. Please let me know ASAP if you > find any weirdness with ipfw after this commit. Thanks. > > -- > Maxim Konovalov, maxim@FreeBSD.org > > ---------- Forwarded message ---------- > Date: Mon, 28 Oct 2002 04:44:16 -0800 (PST) > From: Maxim Konovalov > To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org > Subject: cvs commit: src/sys/netinet ip_fw.c > > maxim 2002/10/28 04:44:16 PST > > Modified files: (Branch: RELENG_4) > sys/netinet ip_fw.c > Log: > o Fix remove_dyn_rule() logic. > o Re-lookup a parent after EXPIRE_DYN_CHAIN(). > o MFC rev. 1.14 ip_fw2.c: do not abuse console with 'session drop' messages. > > PR: kern/32600, kern/35887 > Submitted by: Dan Pelleg > Reviewed by: -stable > > Changes #1 and #2 do not apply to -CURRENT. > > Many thanks to Dan Pelleg , Dmitry Afanasiev > , Eugene Grosbein and Andrew Zavjalov > for testing. > > Revision Changes Path > 1.131.2.36 +17 -4 src/sys/netinet/ip_fw.c > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-stable" in the body of the message Please, please, change LOG_INFO to LOG_DEBUG, "drop session, too many entries\n" isn't informative at all, it does not even show rule number. And if it would, it flood syslog as it could not compress messages. There is really need of opportunity to separate this message from 'ipfw log'. Should I fill PR with obvious patch to make this happen? Eugene Grosbein To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message