Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Oct 2010 08:51:05 +0300
From:      Andriy Gapon <avg@icyb.net.ua>
To:        Lin Ming <ming.m.lin@intel.com>
Cc:        freebsd-acpi@FreeBSD.org, "Moore, Robert" <robert.moore@intel.com>, Jung-uk Kim <jkim@FreeBSD.org>
Subject:   Re: MacBookPro 5,1
Message-ID:  <4CCA60C9.7040600@icyb.net.ua>
In-Reply-To: <4CCA5A3B.9000101@icyb.net.ua>
References:  <201010121209.06397.hselasky@c2i.net>	 <1288278300.2459.19.camel@localhost> <1288279472.2459.22.camel@localhost>	 <201010281810.23668.hselasky@c2i.net> <1288312476.13315.15.camel@minggr.sh.intel.com> <4CCA594C.7050806@icyb.net.ua> <4CCA5A3B.9000101@icyb.net.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
on 29/10/2010 08:23 Andriy Gapon said the following:
> on 29/10/2010 08:19 Andriy Gapon said the following:
[snip]
>> l_prs_template is populated in link_add_prs() function, which called to walk
>> over resources returned by _PRS:
>> http://fxr.watson.org/fxr/source/dev/acpica/acpi_pci_link.c#L499
>> http://fxr.watson.org/fxr/source/dev/acpica/acpi_pci_link.c#L269
>> http://fxr.watson.org/fxr/source/dev/acpica/acpi_pci_link.c#L324
>>
>> So, it would seem that those incorrect lengths would come from evaluation of
>> _PRS by ACPICA code.  But that's probably a naive conclusion, it could be that
>> we incorrectly manipulate a received resource.

I guess that a general problem here is that it is incorrect to merely use
memcpy/bcopy to create a copy of a resource if the resource has
ACPI_RESOURCE_SOURCE field in it.

Is there a helper function for making such a copy?

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CCA60C9.7040600>