From owner-svn-ports-all@freebsd.org Tue Jan 26 18:47:08 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A92FA46FEC for ; Tue, 26 Jan 2016 18:47:08 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 41A49753 for ; Tue, 26 Jan 2016 18:47:08 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: by mail-io0-x231.google.com with SMTP id q21so196135052iod.0 for ; Tue, 26 Jan 2016 10:47:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=helfman-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=gNZQ2I04Zm102lI4hGLjWlJhkOBrOZzXcPF1jdkK1k4=; b=h9ygxNK2C6SwS9Xk4MTQDPEAndwAUeYjAVMjRHa3tlmY57r5itStCayJlSuBe7VHDm Cwf32IN7I6P4bQYaxr08V3IZoEbhBxQOpcM1lKb+XXQitMRzSru4bdp+Y5ZvDIV0V4zG trPhFLX6Pb6tZAC63+TK1QvtbiCo3n8YmYG3y4KL2UlKmrjx0hS5HDW1ONXYnL2iqhKB SQ4nSeRrk2DsHNixq069QB/r1prg7eG/us36+MEIlgWGsGDj9KWZzA8PBtwFAuz4yDwR Fuwcoc+nUoZozF88k254009ZnGle53qHvmirUfK4e2L8Igij0Bdp8+5z6oLt6wAcqC58 MP+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=gNZQ2I04Zm102lI4hGLjWlJhkOBrOZzXcPF1jdkK1k4=; b=Ii/7tZdNb4/d/Og9G0AebImD5wlVF3Wrnqu0g2XwG1c3EeAdFY019T+xnpI1BYMRcl KM1twknWfkHYzyTNe6IxQrU67qej70ODsE641FmFoVYJ0h+sstIC9RS1HRo7uCtLzWn+ Sz/s7dQxbG7pEL/elrAY67zCPIhA/viMhDBwER6HpRcCrt83dRcTnri8RgRvwqldl5uS iAkTXpDwfF4G8eo3XHoyO6lLhCGF/8tFXYfAU3zToFh7asXvlCr7rWHiReg28AXZ5Iay WYruC/O2IOQxk7XNrJQb+L5ImD2/HGfPZGfKZASoBgZqpwXT/5YU9orwrNpPATmrEbGO J+Ng== X-Gm-Message-State: AG10YOQGXKhoSfOdEFzaugbKn7tA3hV7POIQu0wrJvTq8Yy3tBQAEkt82Uyk7uPomCedjNsErhhRBQLCcEt2uQ== MIME-Version: 1.0 X-Received: by 10.107.19.203 with SMTP id 72mr27998864iot.41.1453834027496; Tue, 26 Jan 2016 10:47:07 -0800 (PST) Sender: bsd-src@helfman.org Received: by 10.107.142.66 with HTTP; Tue, 26 Jan 2016 10:47:07 -0800 (PST) In-Reply-To: <20160126182312.GA54534@FreeBSD.org> References: <201601251910.u0PJAdeU003331@repo.freebsd.org> <20160126141038.GA46193@FreeBSD.org> <4C5F6D463ACD91B52D4AC5AF@ogg.in.absolight.net> <20160126153932.GC46193@FreeBSD.org> <20160126182312.GA54534@FreeBSD.org> Date: Tue, 26 Jan 2016 10:47:07 -0800 X-Google-Sender-Auth: XJ2xlwGy6d0QyGA5mV1MR3CC8UA Message-ID: Subject: Re: svn commit: r407237 - head/mail/imaputils From: Jason Helfman To: Alexey Dokuchaev Cc: Jason Helfman , Mathieu Arnold , "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Kurt Jaeger , "ports-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2016 18:47:08 -0000 On Tue, Jan 26, 2016 at 10:23 AM, Alexey Dokuchaev wrote: > On Tue, Jan 26, 2016 at 10:08:26AM -0800, Jason Helfman wrote: > > On Tue, Jan 26, 2016 at 7:39 AM, Alexey Dokuchaev wrote: > > > Right, there are few possible combinations like that; usually I try to > > > give attribution in a way that makes the most sense if read naturally > > > (top to bottom). For example, for the actuall patch submitted by foo, > > > with a related PR (submitted by someone else) it's probably better to > > > put "Submitted by[: foo]" line first, and PR line after. [...] > > > > I did put a PR in for this issue, which could possibly be leveraged and > > clear the commit confusion. The PR adds a "Reported by" to the FreeBSD > > template. > > I don't see the need to put a reference to PR on a follow-up commit that > just had cleaned things up a bit (avoid needless assignment in this case). > > > These are problem reports, and I think it is appropriate to have that > > someone reported a problem report. > > Correct, but this is irrelevant to the commit in question (r407237). > > > If there is a submission associated with the report, it then is very > > clear that it was reported by one person, and another individual > > submitted a fix. > > One of the long-standing traditions of FreeBSD is that we kindly ask folks > not just report the problem ("hey, port foo/bar needs an update!") but also > provide a patch (that is, submission). Hence in general it is *not* clear > that PR was reported by one person, and another individual submitted a fix: > we simply do not (rightfully) encourage this type of workflow, we ask for > patches. :-) > > > I put this in awhile ago, and there was some discussion about it, however > > the PR has not yet been committed at this point. Whether or not this is a > > good solution, or there is something better, is another matter entirely. > > Sorry, I don't think I quite understand this paragraph (particularly, which > PR?). > > ./danfe > > I believe there was a misunderstanding. I wasn't suggesting a follow-up commit. I understand that we ask for a patch, but there are many that are simply reported, and someone else will fix it. This was the reasoning behind submitting this PR. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195252 -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve