From owner-svn-src-head@FreeBSD.ORG  Sat Mar 13 13:53:39 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2CE781065674;
	Sat, 13 Mar 2010 13:53:39 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 054428FC0C;
	Sat, 13 Mar 2010 13:53:39 +0000 (UTC)
Received: from [192.168.2.102] (host86-180-59-125.range86-180.btcentralplus.com
	[86.180.59.125])
	by cyrus.watson.org (Postfix) with ESMTPSA id C914946B6C;
	Sat, 13 Mar 2010 08:53:37 -0500 (EST)
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: "Robert N. M. Watson" <rwatson@FreeBSD.org>
In-Reply-To: <2F4A2F84-4955-49C2-B25E-BB987BC27815@lakerest.net>
Date: Sat, 13 Mar 2010 13:53:36 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <92C0A9B0-9297-4F56-A6A1-603006423230@FreeBSD.org>
References: <201003122258.o2CMwqDM039077@svn.freebsd.org>
	<alpine.BSF.2.00.1003131257060.51476@fledge.watson.org>
	<2F4A2F84-4955-49C2-B25E-BB987BC27815@lakerest.net>
To: Randall Stewart <rrs@lakerest.net>
X-Mailer: Apple Mail (2.1077)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r205104 - in head/sys: dev/xen/netback netinet
	netinet6
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Mar 2010 13:53:39 -0000


On Mar 13, 2010, at 1:50 PM, Randall Stewart wrote:

> did not think of that.. we COULD possible do it another way.. a bit =
harder
> but possible.. i.e. have the delayed sack code actually look into
> the mbufs and see if its ipv4 or ipv6.. I thought about doing it
> that way but it takes more cycles ;-o
>=20
> I could refactor that this way if you want... it would mean a few more =
de-ref's and
> looking to see if its a v4 or v6 packet and then doing the proper =
offset...
>=20
> not to bad but awkward ;-0

Well, I think what I was trying to get across more is that this change =
is OK to merge, but only because you were lucky (or, more arguably, =
there is a Makefile bug). So the best advice is to future-proof =
yourself: keep very close tabs on the use of SCTP symbols and =
definitions outside of the core code, especially in modules, and make =
sure you're entirely happy with KPI/KBI exposures from inception.

Robert=