From owner-svn-src-all@freebsd.org Sun Nov 24 15:10:44 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5AB51B17D8; Sun, 24 Nov 2019 15:10:44 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47LYWm4t4Rz46R9; Sun, 24 Nov 2019 15:10:44 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lf1-x130.google.com with SMTP id b20so8985427lfp.4; Sun, 24 Nov 2019 07:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KsB8B/VnwEd202dEr4iuEVYFWt/ZCWsFaMPzoAbdD9M=; b=hphXf/QxbGHKNo4+gDTh973djvAIsfEAaEszM+fz8/b87Ryy+k+A7AQ/k9fYsDCH3Y t7f6+6dPOMTA/5txDVk41NT8Bxim0KvEXr2TAszzn7w2Z/j1sdTdH+eoGuaqLzFE+wGZ ZCpH7dv2pNl28CeTB5qQIVqQa8Z9y5pHY1gefVMJM8plLht7Zbyp6hgI9soGyCgIF2P0 T27lOkbvofmH7hw+toCvGjsNZwPJs39BUPZpxjuFysvVaolz7bT35+R5mh5n0riqVlEB zGNA1jIOxD5Tv3mPCCE4zYEWEC/SftYtb5wB6B8kLn8kSLhAd6oLEFJFFgka7CnZC1DD 8gOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KsB8B/VnwEd202dEr4iuEVYFWt/ZCWsFaMPzoAbdD9M=; b=lO+t+oOd0GMwl9Tpn51taYadAe61w5CoQluCvAL+b6j27yDJFhtd+7x7tPV5nUn8nF Fi3mRrP4BcrtnUGZD0RXieoSrRSzuO7JlXmm2g10XZlDBqXl8Mnb19cw9tT5VCC6T8bw rKhMIapd4xz1kHkUIgqyDBEHKrUFG1fQEOvpy+YRXIz7Ah7Dcn83190sGDLGaOMNavis 9BoDMJ2y90DAzJz2czqta+jWRQoJw2Qk5uylM7L/6eeKvh/2qAcFCfE/OfnvY4xRey2Q Aq+cJhsNlvFiTFwz1hQsWsKsOevOo3nrS+WeG5szTi4J6oyDEHYmSrICgHS/IXpJOQj5 Kx9A== X-Gm-Message-State: APjAAAXQhMgV3Kdw0Cn3X4QaBXyfW4tFF8+STydy69Sz98mZy6/f2clx DTksTg0QzvhI+vJ4YyNn0NcQSuQ4fd60T9gF0JNZqg== X-Google-Smtp-Source: APXvYqy4yXMKavFi92jeTKycSZPKj0RTZJqiuDg+8EHKmdBQUBWBQE+hh6s9L2k6LYQrbiL0X3/RR/JxQpBbP2IM4BU= X-Received: by 2002:ac2:4312:: with SMTP id l18mr17649721lfh.38.1574608240760; Sun, 24 Nov 2019 07:10:40 -0800 (PST) MIME-Version: 1.0 References: <201911240643.xAO6h3R0046260@repo.freebsd.org> In-Reply-To: <201911240643.xAO6h3R0046260@repo.freebsd.org> From: Justin Hibbits Date: Sun, 24 Nov 2019 09:10:29 -0600 Message-ID: Subject: Re: svn commit: r355047 - head/libexec/rtld-elf/powerpc To: Brandon Bergren Cc: src-committers , svn-src-all , svn-src-head@freebsd.org X-Rspamd-Queue-Id: 47LYWm4t4Rz46R9 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.998,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Nov 2019 15:10:44 -0000 On Sun, Nov 24, 2019, 00:43 Brandon Bergren wrote: > Author: bdragon > Date: Sun Nov 24 06:43:03 2019 > New Revision: 355047 > URL: https://svnweb.freebsd.org/changeset/base/355047 > > Log: > [PowerPC] Fix stack padding issue on ppc32. > > Four bytes of padding are needed in the regular powerpc case to bring the > stack frame size up to a multiple of 16 bytes to meet ABI requirements. > > Fixes odd hangs I was encountering during testing. > > Modified: > head/libexec/rtld-elf/powerpc/rtld_start.S > > Modified: head/libexec/rtld-elf/powerpc/rtld_start.S > > ============================================================================== > --- head/libexec/rtld-elf/powerpc/rtld_start.S Sun Nov 24 05:37:28 2019 > (r355046) > +++ head/libexec/rtld-elf/powerpc/rtld_start.S Sun Nov 24 06:43:03 2019 > (r355047) > @@ -111,7 +111,7 @@ _ENTRY(.rtld_start) > /* stack space for 30 GPRs + lr/cr */ > #define NREGS 30 > #define GPRWIDTH 4 > -#define FUDGE 0 > +#define FUDGE 4 > #endif > /* Stack frame needs the 12-byte ABI frame plus fudge factor. */ > #define STACK_SIZE (NREGS * GPRWIDTH + 4 * 2 + 12 + FUDGE) > Oh right, ABI calls for 16-bye alignment. - Justin >