From owner-svn-src-all@FreeBSD.ORG Wed Dec 30 06:28:37 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 976AD106576C; Wed, 30 Dec 2009 06:28:37 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-px0-f190.google.com (mail-px0-f190.google.com [209.85.216.190]) by mx1.freebsd.org (Postfix) with ESMTP id C744D8FC36; Wed, 30 Dec 2009 06:28:36 +0000 (UTC) Received: by pxi28 with SMTP id 28so7956410pxi.7 for ; Tue, 29 Dec 2009 22:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=aE1NDxk6Rstc/zPHo8Aks25dEX4HSLq/z+JWhkSFA/g=; b=ChAVTomLfBOg6Zk1ZlvRWWiDHeYwmLt1LLKivHLAEsAQ5hUeQVXCCZdMvBDBKa31KP 9uoOhoJVzYARv13XoQA1qnsMwcmEZV2admknZAPztRIUNuR9qeVJQh9iZ2q9uc0rzg0b zx7wxc+o61n6AYXBHtewtxcUPVFX79iwiZmuM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Pw6wDBOR1pN2pHmGIbG3Az9fKQntnPiSsTzKPbfMNmixaXZtdgWszDoPu/BoHkZKkF VOenh6zd66caFakDSNXaLl2ACZy3JI2vuZwpsXskgHBdOnqu7pprNOESCxKp08VpdCTT 12dL+HTedYNNM62jrZ0Lc/U7jcOyYjAxk5lpA= MIME-Version: 1.0 Received: by 10.114.187.7 with SMTP id k7mr4446980waf.106.1262154507325; Tue, 29 Dec 2009 22:28:27 -0800 (PST) In-Reply-To: <20091230062236.GI64905@hoeg.nl> References: <200912292253.nBTMrR5m038869@svn.freebsd.org> <4B3AA7DC.1040606@FreeBSD.org> <20091230062236.GI64905@hoeg.nl> Date: Tue, 29 Dec 2009 22:28:27 -0800 Message-ID: From: Xin LI To: Ed Schouten Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Gabor Kovesdan Subject: Re: svn commit: r201227 - in head: sbin/comcontrol sbin/mount sbin/mount_msdosfs sbin/mount_nullfs sbin/rcorder usr.bin/find usr.bin/gencat usr.bin/mklocale usr.sbin/config usr.sbin/cpucontrol usr.sbin... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2009 06:28:37 -0000 On Tue, Dec 29, 2009 at 10:22 PM, Ed Schouten wrote: > Hi Gabor, > > * Gabor Kovesdan wrote: >> I wonder if it would be worth to invent a WARNS=7 level, which would >> be WARNS=6 + ANSI. Although ANSI-conformance isn't a -Wfoo flag, >> which is WARNS for but conforming ANSI means a higher level >> cleannes, which is demanded, so I think it wouldn't really >> contradict to the semantics of WARNS. > > So far I've been using -Wold-style-definition, which I've been using > make these changes. I am planning on just adding that to WARNS=6, > considering that almost all the code at WARNS=6 builds with this flag > enabled now. > > I'd rather not add a WARNS=7, because then I'm afraid almost nobody will > know about its existence, causing it to be mostly ignored. In an ideal > world, I think we should get rid of WARNS. We could just enable all -W > flags by default, except -Werror. That way people would be invited to > fix the warnings over time. Probably leaving -Werror by default is better... Without -Werror I think there is fewer chance that these issues being noticed. The point of having -Werror is that it means a build break (at the developers' local machine, or tinderbox if he or she didn't do a full universe build), loud enough and can be fixed early rather than letting them go. Historically we only disable -Werror when major compiler change, etc. Cheers, -- Xin LI http://www.delphij.net