Date: Sun, 05 Mar 2023 14:36:54 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 267158] [NEW PORT] devel/arm-compute-library Message-ID: <bug-267158-7788-4tR67cqBJY@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-267158-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-267158-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267158 --- Comment #12 from Robert Clausecker <fuz@FreeBSD.org> --- Thank you for the update. What about the examples? (see comment #5) Is there a reason why they are only built on amd64? The usual convention i= s to have an option EXAMPLES conditionally on which examples are built. I'm not asking you to change this, just to explain your choice so I can understand = the port better. I've also noticed that you have removed the ONLY_FOR_ARCHS bit. If you do = so, please adapt the SCONS_ARGS bit with suitable default values for other architectures. E.g. you could do SCONS_ARGS_amd64=3D neon=3D0 opencl=3D1 examples=3D1 arch=3Dx86_64 SCONS_ARGS_aarch64=3D neon=3D1 opencl=3D0 examples=3D0 arch=3Darm64-v8a SCONS_ARGS_armv7=3D neon=3D1 opencl=3D0 examples=3D0 arch=3Darmv7a SCONS_ARGS_generic=3D ... SCONS_ARGS+=3D os=3Dfreebsd Werror=3D0 embed_kernels=3D0 build= =3Dnative ${SCONS_ARGS_${ARCH}:U${SCONS_ARGS_generic}} I assume the bit about using the right CC and CXX is taken care of by USES=3Dscons? Lastly, something that slipped by last time I reviewed your port: INSTALL_L= IB is for installing shared libraries only. Use INSTALL_DATA for static libra= ries (cf. =C2=A7 5.17.1 Porter's Handbook). This is because INSTALL_LIB possibl= y strips the library, which is fatal for static libraries. And instead of ${CP} -R, consider using COPYTREE_SHARE for installing the include files. I'll do a test run once my ports builder is free (currently processing some other patches). --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-267158-7788-4tR67cqBJY>