From nobody Thu Jun 19 15:53:12 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bNQB12Jljz5yr3v; Thu, 19 Jun 2025 15:53:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bNQB10wX8z4M2d; Thu, 19 Jun 2025 15:53:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750348393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ewuBtl6WEsrm5knpK4YpFYfRhLwKTQg/fgBgpYICFXo=; b=RGKU3Ljce/hxlMFDH66IVdoY/K/ogJ6gKM79QNg9rNBqdP2v/wvQsFRPGlOIbtC8YVGZCc Ow5XDbUzdht/W63NFJcWtClxEgNbM0vYo4KAnIWrM9zeC8M6Uee8RRo0/bi3lF9i7fqjj6 UoZQetX1kA6fMPbChxK0UsIWokmvZzxxIuMK5mUdupMo7g0r4MOVxRn5lg1o9QfA+chpbV YXs8H0Kfh8f1wlMCLUGgcOyDn9EBUVdgDJHWw2cFOFxyMrix9wrYTVmfY2xRsbnrSZtkb4 8pXtJAE3bXlGH4sdqxaj/nn31Acau3vBW+mzl5j5RqLSeSk7qYzbVw5vVqC+gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750348393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ewuBtl6WEsrm5knpK4YpFYfRhLwKTQg/fgBgpYICFXo=; b=mCoEM4YhWUMG6jac0dWirFXNdcnpVf9G5bWgFrsj5yvyIBGxbPocxuzS8oAhxbb1aSdkqQ LVj46MTDZ3G+tWhkBHAAGc4rn9XrI70ZiAEfNQvZh9MY3JTL0dE7LC6webmN/OXiQIn4ZA XBMNjvSrqzZkxIwuZn/fVENCpP0jW6tfwfwacLG12yrvCmApNuBKuCekowxxVc1qJWo9mE uqK20tdGSfy3LYwbZwAulG0jnqUZtcT9+xroYhXK17XTwtY3rcrIlk7q7Y0fTghbCU62Yc QpLJqSx+/hXJjbXrW7UCXTJ4DUCIf3X1AbMi78aDnhxkvt3dB7bBxDZbz/ur2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750348393; a=rsa-sha256; cv=none; b=Hwta9mD9TrDpLWVj+n/4dzyb6wvBKmQflq1pNPABnPI8DQ3TDgKJuOISsMMS06BknH5pOB ChHXg4pzZbrATr3fBuiVLvt0/+qudiG7P3iQSbJPGfRmjNZLFnuho8FkiD5D+8iYIRTlqm PYo2BrotuzQRE57iO6eV8YrJAFmSndVgCWKMVGId0HJQaWGS0FBhXe2gPcYFD52F1LyokJ GF3sVVeYB8/g5YR2ekdG56iuen3MjQuiva2mw7qexfJc+WjqMm85vZ49tK+WrSobpgiCS3 Ynj2vUFLsrU9QL2dVZkuyQ0DWgO9fHNVZa2QwVf7/5y83fFBfqHmrZh8F/UTnA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bNQB10HSFz1Kjy; Thu, 19 Jun 2025 15:53:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55JFrChU071073; Thu, 19 Jun 2025 15:53:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55JFrCiN071070; Thu, 19 Jun 2025 15:53:12 GMT (envelope-from git) Date: Thu, 19 Jun 2025 15:53:12 GMT Message-Id: <202506191553.55JFrCiN071070@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 77613ed4e3d6 - main - pass: Update comments about scsi and devstat List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 77613ed4e3d635198014fd5b4723fb8eaa35d53e Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=77613ed4e3d635198014fd5b4723fb8eaa35d53e commit 77613ed4e3d635198014fd5b4723fb8eaa35d53e Author: Warner Losh AuthorDate: 2025-06-19 14:24:25 +0000 Commit: Warner Losh CommitDate: 2025-06-19 15:52:25 +0000 pass: Update comments about scsi and devstat scsi is the only transport to do tag_action, so is the only one that needs that support in devstat. Make a note of that. nvme and ata do support some ordering, but that's done in the [an]da driver for each of these devices and not for passthru commands and not via these tags. Sponsored by: Netflix --- sys/cam/scsi/scsi_pass.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/cam/scsi/scsi_pass.c b/sys/cam/scsi/scsi_pass.c index 7bf9fa72b245..c3587421c176 100644 --- a/sys/cam/scsi/scsi_pass.c +++ b/sys/cam/scsi/scsi_pass.c @@ -611,9 +611,13 @@ passregister(struct cam_periph *periph, void *arg) softc->flags |= PASS_FLAG_UNMAPPED_CAPABLE; /* - * We pass in 0 for a blocksize, since we don't - * know what the blocksize of this device is, if - * it even has a blocksize. + * We pass in 0 for a blocksize, since we don't know what the blocksize + * of this device is, if it even has a blocksize. + * + * Note: no_tags is valid only for SCSI peripherals, but we don't do any + * devstat accounting for tags on any other transport. SCSI is the only + * transport that uses the tag_action (ata has only vestigial references + * to it, others ignore it entirely). */ cam_periph_unlock(periph); no_tags = (cgd->inq_data.flags & SID_CmdQue) == 0; @@ -974,6 +978,7 @@ passdone(struct cam_periph *periph, union ccb *done_ccb) DEVSTAT_TAG_SIMPLE, DEVSTAT_READ, NULL, &io_req->start_time); break; + /* XXX XPT_NVME_IO and XPT_NVME_ADMIN need cases here for resid */ default: devstat_end_transaction(softc->device_stats, 0, DEVSTAT_TAG_NONE, DEVSTAT_NO_DATA, NULL,