From nobody Thu Aug 21 21:07:05 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c7G9M0qWTz65gh5 for ; Thu, 21 Aug 2025 21:07:19 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c7G9L5vw1z4DTf for ; Thu, 21 Aug 2025 21:07:18 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45a1b05d252so10780705e9.1 for ; Thu, 21 Aug 2025 14:07:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755810437; x=1756415237; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kmoDhK2D50jQ5IptKaBqeFkVXkx99uz4Z6klc2JHDdE=; b=RK4RhOGRWWJVQCl7WZFvg1dvRbhH46kC5rgMLZBvAA1+VNcv8k7TnlZvAUliLxyKv2 wI3BJFcXRTkVbKoCxJfvISD3qBPcgWny6l6kN81b3mracaWIHimO+sxX6n1x9bS2rnde NMf8qDlh+lI22ieuG9o0CRN4ZyWYC5AdB4zuJ+QnEsyP1NWiveDrZCuowEytjzrzMh1B YZr//fEaKkOoj1BEMST8e4sJNCoEvRHrZ+c8mRv21ENxTh7avfzK3lM+NBndg7UZ/GB6 3lVhTkhQ1tmJomja0v111yrYRK/3ovtgmTmDy1u0Tpi8yRVx2lDBFlzVyu/MdYLvQEsJ K/Iw== X-Forwarded-Encrypted: i=1; AJvYcCVyzor1mpX5Z45S3RvnKUajFq8coGlFNraqffcuoFE2hfn2ea8doiF3abAVGG4ThjLB2JDMQUIkLspJ1jYnaZjrNsNC@freebsd.org X-Gm-Message-State: AOJu0YwLNsY5l7Xwbe7Gl5Z+Sw9pazhMTr8DFCNEzcaHvu5dlH+PQ62Y XvAKiBH5y5jLgaVWiBQpQWdXwFaAcK7IOTcuIUIOWJQONtgEnEWDxRchxDrP7XhxEzA= X-Gm-Gg: ASbGnctsAcOt/Y6KpdwaLM3ySFiDIftbCM/STksTEXJy22WKL/uqSIngEB4eT4K3Tii CQNlmmoUImF8rMOoRq+FnGQ5Xg8jXhrOElvpmzfmuF1iDE++a32xQEbDi+ZSKb+cZ1JJQx1VjdY eRTkCAFrKhEL+ruys2rsV4cuelRYZqUxvQ/eepfvUkko0B5v3L1Xm6GPkgJW8r+Odoi9AspiNAJ 0FKcy7Pw23aGD+9BSQZPASui5wTQH5Mr+HGiuTvc+z4pxrfR9My0s4CJEUq/RoqgIvalaCb8ymo 6MBV1PxV/oqt2BjSs+uanzvyZjOKFaY4fBRHUZ5h/nGjmG7OF6jigQdVekqSwmRYHLjTfBQ2JLN pw1ugCnEiZnR533eGWXOYqMvU8gZlIk8lvPVudXGIw1dbY7UHe+dx8ljO+/I= X-Google-Smtp-Source: AGHT+IG/GRuUpbqeRtUGJT195mQNfOTnz22DzmgnKb8fUWNOPVkW7FKgo9B3GcIUNkOZQ8cbWqJ42A== X-Received: by 2002:a05:600c:1d01:b0:458:bfe1:4a81 with SMTP id 5b1f17b1804b1-45b517d3b07mr4714295e9.17.1755810437083; Thu, 21 Aug 2025 14:07:17 -0700 (PDT) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b50de89b1sm11600795e9.13.2025.08.21.14.07.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Aug 2025 14:07:16 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: 267f8c1f4b09 - main - crypto/openssl: make vendor imports easier/less error prone From: Jessica Clarke In-Reply-To: <202508211705.57LH50gR095150@gitrepo.freebsd.org> Date: Thu, 21 Aug 2025 22:07:05 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <39A8B2D8-49D9-4303-A74A-23FB38B867CC@freebsd.org> References: <202508211705.57LH50gR095150@gitrepo.freebsd.org> To: Enji Cooper X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c7G9L5vw1z4DTf On 21 Aug 2025, at 18:05, Enji Cooper wrote: >=20 > The branch main has been updated by ngie: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D267f8c1f4b09431b335d5f48d8458604= 7471f978 >=20 > commit 267f8c1f4b09431b335d5f48d84586047471f978 > Author: Enji Cooper > AuthorDate: 2025-08-01 04:03:33 +0000 > Commit: Enji Cooper > CommitDate: 2025-08-21 17:02:46 +0000 >=20 > crypto/openssl: make vendor imports easier/less error prone >=20 > This change adds a custom BSD makefile containing multiple = high-level PHONY > targets, similar to targets provided by the ports framework. >=20 > The Makefile does the following: > - Reruns Configure with a deterministic set of arguments to ensure = that > all appropriate features have been enabled/disabled in OpenSSL. > - Preens the pkgconfig files to remove duplicate paths in their > `CFLAGS` and `includedir` variables. > - Rebuilds all ASM files to ensure that the content contained is = fresh. > - Rebuilds all manpages to ensure that the content contained in the > manpages is fresh. >=20 > Some additional work needs to be done to make the manpage = regeneration > "operation" reproducible (the date the manpages were generated is > embedded in the files). >=20 > All dynamic configuration previously captured in > `include/openssl/configuration.h` and `include/crypto/bn_conf.h` = has been > moved to `freebsd/include/dynamic_freebsd_configuration.h` and > `freebsd/include/crypto/bn_conf.h`, respectively. This helps > ensure that future updates don't wipe out FreeBSD customizations to > these files, which tune behavior on a per-target architecture = basis, e.g., > ARM vs x86, 32-bit vs 64-bit, etc. >=20 > MFC after: 1 month > Differential Revision: https://reviews.freebsd.org/D51663 Something in this breaks building on macOS (where, as of recently, we build libcrypto as a bootstrap library for use by the certctl bootstrap tool): = /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_s= ock2.c:64:9: error: call to undeclared function 'ktls_enable'; ISO C99 = and later do not support implicit function declarations = [-Wimplicit-function-declaration]=20 ktls_enable(sock);=20 ^=20 = /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_s= ock2.c:202:5: error: call to undeclared function 'ktls_enable'; ISO C99 = and later do not support implicit function declarations = [-Wimplicit-function-declaration]=20 ktls_enable(sock);=20 ^=20 2 errors generated.=20 --- bio_sock2.o ---=20 *** [bio_sock2.o] Error code 1 Presumably you need a BOOTSTRAPPING check somewhere. Jessica