From owner-svn-src-head@freebsd.org Fri Mar 2 21:49:08 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC70CF24CF1; Fri, 2 Mar 2018 21:49:07 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-qt0-x241.google.com (mail-qt0-x241.google.com [IPv6:2607:f8b0:400d:c0d::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77DD27ABBC; Fri, 2 Mar 2018 21:49:07 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-qt0-x241.google.com with SMTP id t6so13703702qtn.9; Fri, 02 Mar 2018 13:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gGHgcTUlV93Q8V0/C7BefpOHMXLk/3d1Sr7J9b/NyQc=; b=EZ1aWcW4qmT5gdbixv/RypWucnT7Gb3C4qogYbGd9xxi/iVl1H0ZclLA82ZWXhyZwE ZbsIxZL43Poa7AQepWw3gc6pFi34OTiuI2nxd4446gmwjKgw92nq375BegYObusyd/dP +yZdFsoOe31TsdTaz2VXpo4z9uInrHCzyCGpKVzqIaKHNrbyA6oHCSZG0x18oFOpM5g0 YaTPj0FaMV6+m3/X/5mEpZNaVIJ3IcTh00bBcruv9vYfn6+t8z9NeykN1s7qT69fh+xP YwfhlcsSnAGXOHSj9aZuiHW/LUN+7P0xU/Wl5tFQ4LLOXSwKC2vkzlRl+tEw4OOIl+Xo Lf0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gGHgcTUlV93Q8V0/C7BefpOHMXLk/3d1Sr7J9b/NyQc=; b=J/yyTwMuMoawjFy5lrOGnT3w/HasGYu/3WqFPFy1gshe7GnPOAsyvz3B1kJackcCYG vTY7Vxn/zZijYKJoLrivmZ74EdOC5/Qqtzx3FSR1L3FUxIrdP8FMtEKpQBRUEqtCHAdQ WkYTdirNE0bViaTIhcX9/spaPJv+ZHvHkm+YuPMm0MtYnorY8feAitPhVKqdhENNzQ6M NASRd7131PkyQI97q5TjKrY80zLp/0nVGmsKJac84hpekm41AhtoIWSs0qrfnM4qDTvm auN+T/mmDeWt3duwFY+5bEFZ9SiKoPd0pMpUL/TY0xuCRh0J7s1txkzunuMqW7g69eWU w6Nw== X-Gm-Message-State: AElRT7FXviwvO0FsFQ5itftvx44NpZf5p3Ze0dg/0wM2D9gz7rQ6Mp3Q 8CWGoJlvoC4WSWH8D3SvXXIvs+2ExcCkuMvk4tRK9w== X-Google-Smtp-Source: AG47ELvG6U8J2YtxhjQbFffHKIfv6YKsaWCIgXWqMX1YmPqbgNmb8gAawzc1NmIjFAX6tFew0vNWYZUCyuqo22M1g0s= X-Received: by 10.200.27.2 with SMTP id y2mr11006834qtj.161.1520027346963; Fri, 02 Mar 2018 13:49:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.35.42 with HTTP; Fri, 2 Mar 2018 13:49:06 -0800 (PST) In-Reply-To: <201803022126.w22LQRKH034839@repo.freebsd.org> References: <201803022126.w22LQRKH034839@repo.freebsd.org> From: Mateusz Guzik Date: Fri, 2 Mar 2018 22:49:06 +0100 Message-ID: Subject: Re: svn commit: r330294 - head/sys/kern To: Mateusz Guzik Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 21:49:08 -0000 On Fri, Mar 2, 2018 at 10:26 PM, Mateusz Guzik wrote: > Author: mjg > Date: Fri Mar 2 21:26:27 2018 > New Revision: 330294 > URL: https://svnweb.freebsd.org/changeset/base/330294 > > Log: > sx: fix adaptive spinning broken in r327397 > > The condition was flipped. > > In particular heavy multithreaded kernel builds on zfs started suffering > due to nested sx locks. > > For instance make -s -j 128 buildkernel: > > before: 3326.67s user 1269.62s system 6981% cpu 1:05.84 total > after: 3365.55s user 911.27s system 6871% cpu 1:02.24 total > > ps. > .-'---`-. .-'---`-. > ,' `. ,' `. > | \ | \ > | \ | \ > \ _ \ \ _ \ > ,\ _ ,'-,/-)\ ,\ _ ,'-,/-)\ > ( * \ \,' ,' ,'-) ( * \ \,' ,' ,'-) > `._,) -',-') `._,) -',-') > \/ ''/ \/ ''/ > ) / / ) / / > / ,'-' / ,'-' > For some reason some people have non-fixed size fonts and keep asking what this is. It's not a squirrel, Admiral Ackbar nor a failed attempt at ascii art. The svnweb version provides a nice view: https://svnweb.freebsd.org/base?view=revision&revision=330294 Courtesy of http://www.asciifacepalm.com/ -- Mateusz Guzik