Date: Tue, 18 Jun 2019 14:53:25 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: =?utf-8?Q?T=C4=B3l?= Coosemans <tijl@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r503385 - head/Mk/Scripts Message-ID: <20190618125325.7hydq4cjfakia4ap@ivaldir.net> In-Reply-To: <20190618144446.29662c8f@kalimero.tijl.coosemans.org> References: <201906031257.x53Cvi9P092541@repo.freebsd.org> <20190615170158.489616a4@kalimero.tijl.coosemans.org> <20190618110414.ngqcgv4gydfkmk6z@ogg.in.absolight.net> <20190618144446.29662c8f@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--j6s4okisacot57kl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 18, 2019 at 02:44:53PM +0200, T=C4=B3l Coosemans wrote: > On Tue, 18 Jun 2019 13:04:14 +0200 Mathieu Arnold <mat@FreeBSD.org> > wrote: > > On Sat, Jun 15, 2019 at 05:01:58PM +0200, T=C4=B3l Coosemans wrote: > >> On Mon, 3 Jun 2019 12:57:44 +0000 (UTC) Mathieu Arnold <mat@FreeBSD.or= g> > >> wrote: > >>> Author: mat > >>> Date: Mon Jun 3 12:57:44 2019 > >>> New Revision: 503385 > >>> URL: https://svnweb.freebsd.org/changeset/ports/503385 > >>>=20 > >>> Log: > >>> Use UCL for pkg-message > >>> =20 > >>> Remain backward compatible but use ucl for the pkg-messages, which = allows to: > >>> - append messages one after the other > >>> - only print message on delete, install, upgrade from a version to = another > >>> =20 > >>> If pkg-message starts with a [ we consider it should be a valid ucl= file > >>> =20 > >>> The format is the following: > >>> [ > >>> { message: "Always print" }, > >>> { message: "package being removed", type: remove }, > >>> { message: "package being installed", type: install }, > >>> { message: "package is being upgraded", type: upgrade }, > >>> { message: "Upgrading from lower than 1.0", maximum_version: "1.0",= type: upgrade }, > >>> { message: "Upgrading from higher than 1.0", minimum_version: "1.0"= , type: upgrade }, > >>> { message: "Upgrading from >1.0 < 3.0", maximum_version: "3.0", min= imum_version: "1.0", > >>> ] > >>> =20 > >>> Because it is ucl one can use some sugar like: > >>> [ > >>> { message =3D <<EOD > >>> formatted > >>> message 'with fancy things' > >>> EOD > >>> }, > >>> } =20 > >>=20 > >> Can this be extended to include these fields: > >> opsys: <operating system this message applies to> > >> osversion: <list of os version ranges this message applies to> > >> arch: <list of architectures this message applies to> > >> options: <list of options that need to be on or off> =20 > >=20 > > I am not sure adding more fields is a good idea. > > It should remain simple, otherwise there is a risk of the pkg-message > > syntax getting bloated, and it is bound to be misused, especially as the > > use case would be very rare. > > It would probably be better to add files to _PKGMESSAGES when the case > > you want to handle presents itself. >=20 > I agree with that actually, but I guess it depends on whether you see > pkg-message as the final version that goes into the package or whether > it's part of the ports tree and still needs to be processed before a > package is created. >=20 > What I'd like to see is that messages that apply to a certain > range of FreeBSD versions are clearly documented as such. The Firefox > message contains something for FreeBSD < 11.3 but the problem has been > fixed already in stable/11. It would also make it easier to remove the > messages when the FreeBSD versions go EoL. Similarly for the options, > the firefox message contains something about a Gvfs/GIO option but there > is no such option. It doesn't really matter to me whether this is done > in the Makefile or in pkg-message. I'm all for putting everything > (except files/ maybe) in the Makefile (all those tiny files in the ports > tree significantly slow down subversion and other file system operations > like grep). I made my thought About the OS version this should be done at the framework level in the ports tee: This information does not need to be within the package, because packages a= re built for a given version. Same goes for the architecture (maybe with the exception of the noarch pack= ages) I don't think those specific build time information should remain within the generated package. That said, the way it has been done, in the framework so far should allow e= asily to do what you do propose, because things are made so we can append message= s to existing pkg-messages. Meaning we can easily extend it. I will soon send pa= tches to review in that direction. Best regards, Bapt --j6s4okisacot57kl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0I3sMACgkQY4mL3PG3 PlrtThAAkkRjtBmxK5DUGZaifu01w2HOUTFxapvIY13P7pIyc+tmbH/LwvMTq/Qa bgcRaJhzq6yTmM54NVXYhZnE4YxJ2RSM62eOnMPrF3eBkSxIG4qTPtT4SGx1rS4X YhB52JYfdrQ7rvrbAWVNznc/jdyQ/8UwIdYBIE9gygVzezgFiiVHGTQEfsZBMguE vUGx0RIZnu8B7n/0h+deqs2FSWS+5rY6dmWATyK38kevmlmUTEZZVV6CWf301nZ8 v5ZgTZ4/Ywgz58t2qZgC1jZwlz4MEzJw1ylIQNbxH5ZuURYBkJL0kssSGDaXAKOk 0hXSeOhNAGSzOlbQycfPnUx8q7vX5LvHsFx3D4KFJ0KfBYKtjfYvNjaN6wEF69OD htYou3SesZ2zhvU3xxalEoOJ3Kj/rDvP4Lgxi/lUIluiZ/l2KGxTnHHqUdfG2mOp sq+SRyRrYC7CbeAgMUUI+V6bVKkQXFlseWTopVIehjwfp4TJqvJjFu8SvArAwrC5 qcTMQIiy4JKvRpHjsQt27Oia3fbuGF2eTBxPdY9b8cfaEtNab1MlDAmjpBu9k28t ectUqnAUJ8Klwphz897ia+fmLyGiagR4QNqeLDlBlp4lCbeFd4bC2OA3mUctxuBu B1aycnxqS9eTbQnLlIKNNbiOxuHqSccixpC5kkYdbx8wLEUe6j4= =1AZp -----END PGP SIGNATURE----- --j6s4okisacot57kl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190618125325.7hydq4cjfakia4ap>