From nobody Sat Dec 24 21:15:58 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NfcKW2Kb2z1Lnw1; Sat, 24 Dec 2022 21:15:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NfcKW1RMKz49YG; Sat, 24 Dec 2022 21:15:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671916559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GuT7mF3QXSIaTaEOf+g5f3koJg98PlJyDX7PcrZzdbI=; b=WMjdgUO7gYBlyf+0gQ8Jjcg/FSYq/Bj7gkRZGfJ6zp6ZxvPPErlnTGJMS43u1OkfwvmhUX DjGQieNH3Z9PVaS0K54+wHeHUsRsdawTFSWVOWLAknGcabWRlgyMp22LmAkML0fH2/GZ11 S4+L0ZIzuP0ZqkBITiYOSJZ4OLWW3g/xr+8mqCAaPnIsH2oXV0XlyvktZfEQEL3cjeo/3O ZoxUUlNJRUokQzTQCRSGN4MhwOMRnMLEOed3Tnh+8LrgEaevv/4S3JBECXrMSsAEfKgdA+ WYkayRayMMMmtERMA/z5cXoETTawdJ5WlWc/cA9jW1fujEof+6OkVFHJKJcK9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671916559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GuT7mF3QXSIaTaEOf+g5f3koJg98PlJyDX7PcrZzdbI=; b=WyKTFZT7J9uuK7OCFLrGxy0QlNm42z0Fly47pXDyYAljLgvNgxpkwvuPc1x1bgRcJO/jPu QmysNIXu6myoFIniheAlvPRxHgXVio6idNGCqMWR2pQOSBuzv7s5uBkhzNH72fk2tmvsb/ TIEVPYRwwPPgz7VYV35nRZTSOAtWvD7vrPLkzx2+PLHNtoNet1BSZGa/P9/Ns0TpRrOWL/ //06t1Y8ybD5HuWaVaV4iBOUOdMsNx3ObokwKprRJJ8XyGjENKdOizB+eeecSFpLGDGmNo sAB2VAcTTNk9Iz06Wg+cmfkRfzPm4dhMJ9wex9mTOIXylcCn7BxiOBR5+5/AMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671916559; a=rsa-sha256; cv=none; b=G1TOrippCeSo6C/5a031LGkOt20q3aYNXHr76zNC2WKt/mZcNH3TEca7xkegFv43+fCuxU 7MQv0m8VXWBgz86EFsiiCpwLibxVVDdxMmcMyj9R2dzxvoLN3cT30fJX0x/80OFe8sg8vw VsASfg+PepFoDejxOlO7yqsPJMY9Zs0q2DK/MoYbePEeHfC/LPKo/w86AtsoTaEeCEZ5ZP kMDHicgHwoL66zUez+0D0DJjD+tMqveErk4l2yO3OCPCkJ48ITayp8c/iOjKIgLuRkeyL3 rBXmKKlgZ3posqgLCcxapI6i374vulkm/5BuIrFp4+mSh49WEPTxHyLiK1KX4Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NfcKW0N4xzS0T; Sat, 24 Dec 2022 21:15:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BOLFw7T074073; Sat, 24 Dec 2022 21:15:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BOLFwtD074072; Sat, 24 Dec 2022 21:15:58 GMT (envelope-from git) Date: Sat, 24 Dec 2022 21:15:58 GMT Message-Id: <202212242115.2BOLFwtD074072@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 57cc27a3325a - main - BBLog: improve sysctl variables List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 57cc27a3325af74553e852851d5e84e308ae79f4 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=57cc27a3325af74553e852851d5e84e308ae79f4 commit 57cc27a3325af74553e852851d5e84e308ae79f4 Author: Cheng Cui AuthorDate: 2022-12-24 21:10:31 +0000 Commit: Michael Tuexen CommitDate: 2022-12-24 21:10:31 +0000 BBLog: improve sysctl variables Correct the format in sysctl net.inet.tcp.bb.disable_all and sysctl net.inet.tcp.bb.log_auto_all. Correct the format and the description in net.inet.tcp.bb.log_auto_mode. Reviewed by: rscheff, tuexen MFC after: 1 week Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D37776 --- sys/netinet/tcp_log_buf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/netinet/tcp_log_buf.c b/sys/netinet/tcp_log_buf.c index cefd194d4e85..a147b201b2fd 100644 --- a/sys/netinet/tcp_log_buf.c +++ b/sys/netinet/tcp_log_buf.c @@ -114,18 +114,18 @@ SYSCTL_U32(_net_inet_tcp_bb, OID_AUTO, log_version, CTLFLAG_RD, &tcp_log_version 0, "Version of log formats exported"); SYSCTL_U32(_net_inet_tcp_bb, OID_AUTO, disable_all, CTLFLAG_RW, - &tcp_disable_all_bb_logs, TCP_LOG_STATE_HEAD_AUTO, + &tcp_disable_all_bb_logs, 0, "Disable all BB logging for all connections"); SYSCTL_ULONG(_net_inet_tcp_bb, OID_AUTO, log_auto_ratio, CTLFLAG_RW, &tcp_log_auto_ratio, 0, "Do auto capturing for 1 out of N sessions"); SYSCTL_U32(_net_inet_tcp_bb, OID_AUTO, log_auto_mode, CTLFLAG_RW, - &tcp_log_auto_mode, TCP_LOG_STATE_HEAD_AUTO, - "Logging mode for auto-selected sessions (default is TCP_LOG_STATE_HEAD_AUTO)"); + &tcp_log_auto_mode, 0, + "Logging mode for auto-selected sessions (default is TCP_LOG_STATE_TAIL)"); SYSCTL_BOOL(_net_inet_tcp_bb, OID_AUTO, log_auto_all, CTLFLAG_RW, - &tcp_log_auto_all, false, + &tcp_log_auto_all, 0, "Auto-select from all sessions (rather than just those with IDs)"); #ifdef TCPLOG_DEBUG_COUNTERS