Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Dec 2022 21:15:58 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 57cc27a3325a - main - BBLog: improve sysctl variables
Message-ID:  <202212242115.2BOLFwtD074072@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=57cc27a3325af74553e852851d5e84e308ae79f4

commit 57cc27a3325af74553e852851d5e84e308ae79f4
Author:     Cheng Cui <Cheng.Cui@netapp.com>
AuthorDate: 2022-12-24 21:10:31 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2022-12-24 21:10:31 +0000

    BBLog: improve sysctl variables
    
    Correct the format in sysctl net.inet.tcp.bb.disable_all and
    sysctl net.inet.tcp.bb.log_auto_all.
    Correct the format and the description in
    net.inet.tcp.bb.log_auto_mode.
    
    Reviewed by:            rscheff, tuexen
    MFC after:              1 week
    Sponsored by:           NetApp, Inc.
    Differential Revision:  https://reviews.freebsd.org/D37776
---
 sys/netinet/tcp_log_buf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sys/netinet/tcp_log_buf.c b/sys/netinet/tcp_log_buf.c
index cefd194d4e85..a147b201b2fd 100644
--- a/sys/netinet/tcp_log_buf.c
+++ b/sys/netinet/tcp_log_buf.c
@@ -114,18 +114,18 @@ SYSCTL_U32(_net_inet_tcp_bb, OID_AUTO, log_version, CTLFLAG_RD, &tcp_log_version
     0, "Version of log formats exported");
 
 SYSCTL_U32(_net_inet_tcp_bb, OID_AUTO, disable_all, CTLFLAG_RW,
-    &tcp_disable_all_bb_logs, TCP_LOG_STATE_HEAD_AUTO,
+    &tcp_disable_all_bb_logs, 0,
     "Disable all BB logging for all connections");
 
 SYSCTL_ULONG(_net_inet_tcp_bb, OID_AUTO, log_auto_ratio, CTLFLAG_RW,
     &tcp_log_auto_ratio, 0, "Do auto capturing for 1 out of N sessions");
 
 SYSCTL_U32(_net_inet_tcp_bb, OID_AUTO, log_auto_mode, CTLFLAG_RW,
-    &tcp_log_auto_mode, TCP_LOG_STATE_HEAD_AUTO,
-    "Logging mode for auto-selected sessions (default is TCP_LOG_STATE_HEAD_AUTO)");
+    &tcp_log_auto_mode, 0,
+    "Logging mode for auto-selected sessions (default is TCP_LOG_STATE_TAIL)");
 
 SYSCTL_BOOL(_net_inet_tcp_bb, OID_AUTO, log_auto_all, CTLFLAG_RW,
-    &tcp_log_auto_all, false,
+    &tcp_log_auto_all, 0,
     "Auto-select from all sessions (rather than just those with IDs)");
 
 #ifdef TCPLOG_DEBUG_COUNTERS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202212242115.2BOLFwtD074072>