Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 May 2025 03:30:40 GMT
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 0596b4a3d42f - main - vfs_cache.c: Use CACHE_FPL_SUPPORTED_CN_FLAGS
Message-ID:  <202505260330.54Q3UeQW089520@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by rmacklem:

URL: https://cgit.FreeBSD.org/src/commit/?id=0596b4a3d42f0e642f0b5f34b18d43fc8feec46f

commit 0596b4a3d42f0e642f0b5f34b18d43fc8feec46f
Author:     Rick Macklem <rmacklem@FreeBSD.org>
AuthorDate: 2025-05-26 03:27:17 +0000
Commit:     Rick Macklem <rmacklem@FreeBSD.org>
CommitDate: 2025-05-26 03:27:17 +0000

    vfs_cache.c: Use CACHE_FPL_SUPPORTED_CN_FLAGS
    
    Commit 2ec2ba7e232d added some code to cache_can_fplookup()
    which worked (ensuring an abort when OPENNNAMED was set),
    but showed I didn't understand what
    CACHE_FPL_SUPPORTED_CN_FLAGS was used for.
    
    This patch cleans it up.
    
    Reviewed by:    markj
    Differential Revision:  https://reviews.freebsd.org/D50524
    Fixes:  2ec2ba7e232d ("vfs: Add VFS/syscall support for Solaris style extended attributes")
---
 sys/kern/vfs_cache.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index 69de06cff193..e2020b56f038 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -4456,7 +4456,7 @@ cache_fpl_terminated(struct cache_fpl *fpl)
 	(NC_NOMAKEENTRY | NC_KEEPPOSENTRY | LOCKLEAF | LOCKPARENT | WANTPARENT | \
 	 FAILIFEXISTS | FOLLOW | EMPTYPATH | LOCKSHARED | ISRESTARTED | WILLBEDIR | \
 	 ISOPEN | NOMACCHECK | AUDITVNODE1 | AUDITVNODE2 | NOCAPCHECK | OPENREAD | \
-	 OPENWRITE | WANTIOCTLCAPS | OPENNAMED)
+	 OPENWRITE | WANTIOCTLCAPS)
 
 #define CACHE_FPL_INTERNAL_CN_FLAGS \
 	(ISDOTDOT | MAKEENTRY | ISLASTCN)
@@ -4520,10 +4520,6 @@ cache_can_fplookup(struct cache_fpl *fpl)
 		cache_fpl_aborted_early(fpl);
 		return (false);
 	}
-	if ((cnp->cn_flags & OPENNAMED) != 0) {
-		cache_fpl_aborted_early(fpl);
-		return (false);
-	}
 	return (true);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202505260330.54Q3UeQW089520>