Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Oct 2011 08:22:42 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Kostik Belousov <kostikbel@gmail.com>
Cc:        svn-src-head@freebsd.org, David Schultz <das@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org
Subject:   Re: svn commit: r226606 - in head/lib/libc: amd64 amd64/gen arm arm/gen gen i386 i386/gen ia64 ia64/gen mips mips/gen powerpc powerpc/gen powerpc64 powerpc64/gen sparc64 sparc64/gen
Message-ID:  <201110210822.42227.jhb@freebsd.org>
In-Reply-To: <20111021081201.GH50300@deviant.kiev.zoral.com.ua>
References:  <201110210640.p9L6eaeC010594@svn.freebsd.org> <20111021081201.GH50300@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, October 21, 2011 4:12:01 am Kostik Belousov wrote:
> On Fri, Oct 21, 2011 at 06:40:36AM +0000, David Schultz wrote:
> > Author: das
> > Date: Fri Oct 21 06:40:36 2011
> > New Revision: 226606
> > URL: http://svn.freebsd.org/changeset/base/226606
> > 
> > Log:
> >   Replace a proliferation of buggy MD implementations of modf() with a
> >   working MI one.  The MI one only needs to be overridden on machines
> >   with non-IEEE754 arithmetic.  (The last supported one was the VAX.)
> >   It can also be overridden if someone comes up with a faster one that
> >   actually passes the regression tests -- but this is harder than it sounds.
> > 
> > Added:
> >   head/lib/libc/gen/modf.c
> >      - copied, changed from r226410, head/lib/msun/src/s_modf.c
> > Deleted:
> >   head/lib/libc/amd64/gen/modf.S
> >   head/lib/libc/arm/gen/modf.c
> >   head/lib/libc/i386/gen/modf.S
> >   head/lib/libc/ia64/gen/modf.c
> >   head/lib/libc/mips/gen/modf.S
> >   head/lib/libc/mips/gen/modf.c
> >   head/lib/libc/powerpc/gen/modf.c
> >   head/lib/libc/powerpc64/gen/modf.c
> >   head/lib/libc/sparc64/gen/modf.S
> > Modified:
> >   head/lib/libc/amd64/Symbol.map
> >   head/lib/libc/amd64/gen/Makefile.inc
> >   head/lib/libc/arm/Symbol.map
> >   head/lib/libc/arm/gen/Makefile.inc
> >   head/lib/libc/gen/Makefile.inc
> >   head/lib/libc/gen/Symbol.map
> >   head/lib/libc/i386/Symbol.map
> >   head/lib/libc/i386/gen/Makefile.inc
> >   head/lib/libc/ia64/Symbol.map
> >   head/lib/libc/ia64/gen/Makefile.inc
> >   head/lib/libc/mips/Symbol.map
> >   head/lib/libc/mips/gen/Makefile.inc
> >   head/lib/libc/powerpc/Symbol.map
> >   head/lib/libc/powerpc/gen/Makefile.inc
> >   head/lib/libc/powerpc64/Symbol.map
> >   head/lib/libc/powerpc64/gen/Makefile.inc
> >   head/lib/libc/sparc64/Symbol.map
> >   head/lib/libc/sparc64/gen/Makefile.inc
> > 
> > Modified: head/lib/libc/amd64/Symbol.map
> > ==============================================================================
> > --- head/lib/libc/amd64/Symbol.map	Fri Oct 21 06:36:40 2011	(r226605)
> > +++ head/lib/libc/amd64/Symbol.map	Fri Oct 21 06:40:36 2011	(r226606)
> > @@ -26,7 +26,6 @@ FBSD_1.0 {
> >  	__infinity;
> >  	__nan;
> >  	makecontext;
> > -	modf;
> >  	rfork_thread;
> >  	setjmp;
> >  	longjmp;
> You cannot do this, you just completely broke the ABI.
> The symbols must not be removed from the versioned library.

He just moved it to the MI Symbol.map, he didn't remove it:

Modified: head/lib/libc/gen/Symbol.map
==============================================================================
--- head/lib/libc/gen/Symbol.map        Fri Oct 21 06:36:40 2011        (r226605)
+++ head/lib/libc/gen/Symbol.map        Fri Oct 21 06:40:36 2011        (r226606)
@@ -213,6 +213,7 @@ FBSD_1.0 {
        ldexp;
        lockf;
        lrand48;
+       modf;
        mrand48;
        nftw;
        nice;


-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110210822.42227.jhb>