Date: Tue, 4 Jan 2011 08:58:48 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@freebsd.org, Eitan Adler <lists@eitanadler.com>, hackers@freebsd.org, Giorgos Keramidas <keramida@freebsd.org>, Kostik Belousov <kostikbel@gmail.com> Subject: Re: [patch] have rtprio check that arguments are numeric; change atoi to strtol Message-ID: <0CC6BFE3-3381-401A-A9E3-26EB7EB46A3E@gmail.com> In-Reply-To: <20110104134940.GA8529@freebsd.org> References: <AANLkTimiJPiHBSw5i5TVJYfh9uGOyrNJx%2BoUPeB%2Bt%2BY_@mail.gmail.com> <xeia7heluf2q.fsf@kobe.laptop> <20110104112502.GM3140@deviant.kiev.zoral.com.ua> <201101040805.59412.jhb@freebsd.org> <20110104134940.GA8529@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 4, 2011, at 5:49 AM, Alexander Best wrote:
> On Tue Jan 4 11, John Baldwin wrote:
>> On Tuesday, January 04, 2011 6:25:02 am Kostik Belousov wrote:
>>> On Tue, Jan 04, 2011 at 11:40:45AM +0100, Giorgos Keramidas wrote:
>>> @@ -123,12 +121,28 @@ main(argc, argv)
>>> }
>>> exit(0);
>>> }
>>> - exit (1);
>>> + exit(1);
>>> +}
>>> +
>>> +static int
>>> +parseint(const char *str, const char *errname)
>>> +{
>>> + char *endp;
>>> + long res;
>>> +
>>> + errno = 0;
>>> + res = strtol(str, &endp, 10);
>>> + if (errno != 0 || endp == str || *endp != '\0')
>>> + err(1, "%s shall be a number", errname);
>>
>> Small nit, maybe use 'must' instead of 'shall'.
>
> it seems at some point there has been a massive usage of the term 'shall' in
> manual pages, which people tried to get rid of. hence the
> 'usr/share/examples/mdoc/deshallify.sh' script.
I know shall is used widely by opengroup when describing definitions and interfaces in the POSIX standards, but the connotation in English is very squishy, so I agree with John that must would be better.
BTW, only if errno was non-zero would using err(3) be logical. Otherwise it will just produce noise :).
> maybe this should be noted in style(9)?
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0CC6BFE3-3381-401A-A9E3-26EB7EB46A3E>