Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Feb 2023 22:29:19 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,  dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 0fce2dc15730 - main - LinuxKPI,lindebugfs: add u8 base type and blob support
Message-ID:  <r5sp8po3-qnso-53rq-rrqr-94771snp8o13@SerrOFQ.bet>
In-Reply-To: <3e74025f-eedf-7ca2-a5a0-b3971dfdfe30@FreeBSD.org>
References:  <202211281724.2ASHOxU9080511@gitrepo.freebsd.org> <3e74025f-eedf-7ca2-a5a0-b3971dfdfe30@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 6 Feb 2023, John Baldwin wrote:

Hi John,

> On 11/28/22 9:24 AM, Bjoern A. Zeeb wrote:
>> The branch main has been updated by bz:
>> 
>> URL: 
>> https://cgit.FreeBSD.org/src/commit/?id=0fce2dc1573019d0732f33fa7c26cc228655d3e8
>> 
>> commit 0fce2dc1573019d0732f33fa7c26cc228655d3e8
>> Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
>> AuthorDate: 2022-10-22 18:12:16 +0000
>> Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
>> CommitDate: 2022-11-28 17:21:50 +0000
>>
>>      LinuxKPI,lindebugfs: add u8 base type and blob support
>>           Add debugfs_create_u8() based on other already present 
>> implementations.
>>      Add a read-only implementation for debugfs_create_blob().
>>           Both are needed for iwlwifi debugfs support.
>
> This passes kernel pointers to copyout because debugfs is kind of broken due 
> to
> quirks in how linux file operations are implemented.

I'll take this offline with you and jfree@ as there's also another open
review for similar reasons and confusions.  We should get the larger
picture fixed.

/bz

-- 
Bjoern A. Zeeb                                                     r15:7



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?r5sp8po3-qnso-53rq-rrqr-94771snp8o13>