From owner-freebsd-fs@FreeBSD.ORG  Tue Apr 21 17:01:45 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E955106567A
	for <freebsd-fs@freebsd.org>; Tue, 21 Apr 2009 17:01:45 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 689E58FC14
	for <freebsd-fs@freebsd.org>; Tue, 21 Apr 2009 17:01:44 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA18979;
	Tue, 21 Apr 2009 19:45:04 +0300 (EEST)
	(envelope-from avg@icyb.net.ua)
Message-ID: <49EDF80F.3070105@icyb.net.ua>
Date: Tue, 21 Apr 2009 19:45:03 +0300
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.21 (X11/20090406)
MIME-Version: 1.0
To: Ivan Voras <ivoras@freebsd.org>
References: <49EDCA21.70908@icyb.net.ua> <gskrld$vo0$1@ger.gmane.org>
In-Reply-To: <gskrld$vo0$1@ger.gmane.org>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org
Subject: Re: glabel for ufs: size check is overzealous?
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2009 17:01:46 -0000

on 21/04/2009 19:18 Ivan Voras said the following:
> Andriy Gapon wrote:
>> glabel insists that for UFS2 the following must hold true:
>> pp->mediasize / fs->fs_fsize == fs->fs_size
>>
>> But in reality it doesn't have to be this way, there can be valid reasons to make
>> filesystem smaller than available raw media size.
>>
>> I understand that this is a good sanity check, but maybe there are other ways to
>> extra-check that we see a proper superblock, without imposing the limitation in
>> question.
> 
> Shouldn't fsck complain of this inconsistency?

I don't see why it should and - no, it actually does not.
fsck checks only filesystem's internal consistency, it doesn't check media size, etc.

> If it doesn't and the [UF]FS code doesn't, I don't see why glabel should
> continue to check it. Struct fs has a tonne of int32 fields, some of
> which are only used for information whose length is a couple of bits -
> if checking magic isn't enough (and it probably is), there are other
> fields that can be validated.

Maybe this is a check against disk space being re-used for some other fs and
super-block staying sufficiently intact. But, OTOH, fs_fsize and fs_size could
still match the raw media in this case too.
If some extra sanity checks are needed in addition to magic then
fs_bmask/fs_fmask/fs_bshift/fs_fshift and/or any other derived fields could be used.

-- 
Andriy Gapon