From owner-svn-src-head@freebsd.org Fri Jan 13 12:47:48 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 28A46CAEC1B; Fri, 13 Jan 2017 12:47:48 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mailout.stack.nl (mailout05.stack.nl [IPv6:2001:610:1108:5010::202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mailout.stack.nl", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E7A451C88; Fri, 13 Jan 2017 12:47:47 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mailout.stack.nl (Postfix) with ESMTP id D471F35; Fri, 13 Jan 2017 13:47:36 +0100 (CET) Received: by snail.stack.nl (Postfix, from userid 1677) id C389128494; Fri, 13 Jan 2017 13:47:36 +0100 (CET) Date: Fri, 13 Jan 2017 13:47:36 +0100 From: Jilles Tjoelker To: "Ngie Cooper (yaneurabeya)" Cc: Craig Rodrigues , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r286649 - in head: contrib/netbsd-tests/lib/libc/locale lib/libc/tests/locale Message-ID: <20170113124736.GA91713@stack.nl> References: <201508112159.t7BLxa6U057950@repo.freebsd.org> <681075F8-78D1-43FF-A75D-71D5CDBA3AB4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <681075F8-78D1-43FF-A75D-71D5CDBA3AB4@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 12:47:48 -0000 On Wed, Jan 11, 2017 at 02:14:13AM -0800, Ngie Cooper (yaneurabeya) wrote: > > On Aug 11, 2015, at 6:45 PM, Craig Rodrigues wrote: > > > > On Tue, Aug 11, 2015 at 2:59 PM, Jilles Tjoelker > wrote: > > Author: jilles > > Date: Tue Aug 11 21:59:36 2015 > > New Revision: 286649 > > URL: https://svnweb.freebsd.org/changeset/base/286649 > > Log: > > Fix and re-enable UTF-8 tests. > > Modified: > > head/contrib/netbsd-tests/lib/libc/locale/t_mbrtowc.c > > head/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c > > head/lib/libc/tests/locale/Makefile > > Thanks for fixing this. What is the procedure that FreeBSD > > developers need to follow to push this kind of change upstream to > > NetBSD? > I’m submitting PRs with NetBSD as needed. To be frank, I’m not > sure that this change is needed upstream (I’m probably going to #ifdef > the code — some things I found when trying to push things back). I think the change is required upstream as well, since UTF-8 no longer includes code points greater than 0x10ffff per RFC 3629 (this change made the code point ranges of UTF-8 and UTF-16 the same). The sequences that used to correspond to code points greater than 0x10ffff shall be treated as invalid. See also SVN r286490, r286491, r287125. I suppose I should have included this reasoning in the original commit message. -- Jilles Tjoelker