From owner-svn-src-all@FreeBSD.ORG Tue Oct 28 15:52:22 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D94B0C88 for ; Tue, 28 Oct 2014 15:52:22 +0000 (UTC) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69F0CE67 for ; Tue, 28 Oct 2014 15:52:22 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id hi2so6192971wib.10 for ; Tue, 28 Oct 2014 08:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=JfTA3z2ZvViz0R1JSAE+BW430nAn5YTnAPSpK/+GvPo=; b=lOhHXCZZV4JJIKlplj/bxzRr8Wutn9S4TI4s5D6PgOnuXagz+auE3dJZzLl30+Trkz UAcnAhjTXqz09MTbRX2gVhTsfM4ZJioO5D1cp3pNsI83KQHF3wuHhB+dNZw7YgkJwGSP koLkUxKgN4TxTAI+wkgpgHcJe/Tf7RssbscFyCNM16CvDjIxIjunF6x8UGdHfgakAac+ cXkfuVVk8j4vymOL5Xr9FF5z+Iv5PsTIcPIcZRgJLMkoe23XVG5ps4WUQBL0xojweHUG simIEHUZrxMVEy4aX+I6MJqaqCMeYvgLvk9ewTWXJGbq6A58W6irETHfYQ65LjpQsTXg CAJw== X-Received: by 10.194.122.231 with SMTP id lv7mr5459148wjb.27.1414511540637; Tue, 28 Oct 2014 08:52:20 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id h8sm2246288wjs.43.2014.10.28.08.52.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Oct 2014 08:52:19 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 28 Oct 2014 16:52:17 +0100 From: "bapt@FreeBSD.org >> Baptiste Daroussin" To: Adam McDougall Subject: Re: svn commit: r273782 - in head/usr.sbin/pw: . tests Message-ID: <20141028155217.GD26796@ivaldir.etoilebsd.net> References: <201410281454.s9SEs5kb098825@svn.freebsd.org> <544FB7DA.8010502@egr.msu.edu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0/kgSOzhNoDC5T3a" Content-Disposition: inline In-Reply-To: <544FB7DA.8010502@egr.msu.edu> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 15:52:22 -0000 --0/kgSOzhNoDC5T3a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 28, 2014 at 11:35:54AM -0400, Adam McDougall wrote: > On 10/28/2014 10:54, Baptiste Daroussin wrote: > > Author: bapt > > Date: Tue Oct 28 14:54:04 2014 > > New Revision: 273782 > > URL: https://svnweb.freebsd.org/changeset/base/273782 > >=20 > > Log: > > Do not delete the group wheel when bad argument is passed to pw group= del -g > > =20 > > Check that the -g argument is actually a number, if not report an err= or. > > This argument is converted without checking with atoi(3) later so wit= hout this > > check it converts any alpha entries into 0 meaning it deletes the gro= up wheel > > =20 > > Add a regression test about it > > =20 > > PR: 90114 > > Reported by: bkoenig@cs.tu-berlin.de > > MFC after: 1 week > >=20 > > Modified: > > head/usr.sbin/pw/pw_group.c > > head/usr.sbin/pw/tests/pw_delete.sh >=20 > Would you mind looking at this related pw bug with patch? Thanks. >=20 > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D187189 I will yes regards, Bapt --0/kgSOzhNoDC5T3a Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlRPu7EACgkQ8kTtMUmk6EyTiwCeP9HMyETRBNJS8mgZ2hmFWnin 6zAAnRbBjiBnhBBnYHOmjPA/Vt+/qmN2 =tB46 -----END PGP SIGNATURE----- --0/kgSOzhNoDC5T3a--