From owner-freebsd-toolchain@freebsd.org  Sat Sep  9 22:53:53 2017
Return-Path: <owner-freebsd-toolchain@freebsd.org>
Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66C9EE0FD2F
 for <freebsd-toolchain@mailman.ysv.freebsd.org>;
 Sat,  9 Sep 2017 22:53:53 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from pmta2.delivery6.ore.mailhop.org
 (pmta2.delivery6.ore.mailhop.org [54.200.129.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4879680EA1
 for <freebsd-toolchain@freebsd.org>; Sat,  9 Sep 2017 22:53:52 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: bb51ea2f-95b1-11e7-b50b-53dc5ecda239
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.78.92.27
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.78.92.27])
 by outbound2.ore.mailhop.org (Halon) with ESMTPSA
 id bb51ea2f-95b1-11e7-b50b-53dc5ecda239;
 Sat, 09 Sep 2017 22:53:44 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id v89MriRK004711;
 Sat, 9 Sep 2017 16:53:44 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1504997624.32063.69.camel@freebsd.org>
Subject: Re: if_igb.ko symbolic link generation is still messed up in that
 it hard wires the path at installkernel time, messing up copying to other
 places
From: Ian Lepore <ian@freebsd.org>
To: "Simon J. Gerraty" <sjg@juniper.net>, Mark Millard <markmi@dsl-only.net>
Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, FreeBSD Current
 <freebsd-current@freebsd.org>
Date: Sat, 09 Sep 2017 16:53:44 -0600
In-Reply-To: <75575.1504996310@kaos.jnpr.net>
References: <FCCBB38A-CE76-4F20-80E7-EA3640F5EFC5@dsl-only.net>
 <75575.1504996310@kaos.jnpr.net>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Sep 2017 22:53:53 -0000

On Sat, 2017-09-09 at 15:31 -0700, Simon J. Gerraty wrote:
> Mark Millard <markmi@dsl-only.net> wrote:
> > 
> > # ls -lTt /media/boot/kernel/if_igb.ko /mnt/boot/kerndb/if_igb.ko
> > lrwxr-xr-x  1 root  wheel  25 Sep  8 22:47:36 2017
> > /mnt/boot/kerndb/if_igb.ko -> /mnt/boot/kernel/if_em.ko
> > lrwxr-xr-x  1 root  wheel  68 Sep  6 20:27:20 2017
> > /media/boot/kernel/if_igb.ko -> /usr/obj/DESTDIRs/clang-cortexA53-
> > installkernel/boot/kernel/if_em.ko
> > 
> > In both of these cases the /mnt and /usr/obj/DESTDIRs/ prefixes
> > would not exist for booting the PINE64 that the USB SSD is for:
> > so file not found if a usage attempt is made.
> Yes, when making symlinks in presence of DESTDIR, the src should have
> $DESTDIR removed - the following should usually be safe:
> 
> ln -s ${src#$DESTDIR} $DESTDIR${target#$DESTDIR}
> 

I think the modern fix for this would be "install -l rs $src $DESTDIR",
that should result in if_igb.ko -> if_em.ko without any dir nodes in
the link.

-- Ian