From owner-svn-src-head@freebsd.org Wed Jun 6 14:22:18 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41FA2FF7D22; Wed, 6 Jun 2018 14:22:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E790F76AC4; Wed, 6 Jun 2018 14:22:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id CA0122BD3; Wed, 6 Jun 2018 14:22:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 1B4D15C43; Wed, 6 Jun 2018 14:22:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 0S7-514IDFDa; Wed, 6 Jun 2018 14:22:14 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 80E895C40 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r334226 - head/lib/libpmcstat/pmu-events From: Bryan Drewery X-Mailer: iPhone Mail (15E302) In-Reply-To: Date: Wed, 6 Jun 2018 10:22:12 -0400 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <22DC270C-75B9-4219-B022-AF1C3E9022F0@FreeBSD.org> References: <201805252146.w4PLk7vL009258@repo.freebsd.org> To: Kyle Evans X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2018 14:22:18 -0000 Will look today or tomorrow. Pretty sure just a small thing is missing from M= akefile.libcompat. Regards, Bryan Drewery > On Jun 5, 2018, at 00:32, Kyle Evans wrote: >=20 >> On Mon, Jun 4, 2018 at 10:11 PM, Kyle Evans wrote: >>> On Fri, May 25, 2018 at 4:46 PM, Bryan Drewery wr= ote: >>> Author: bdrewery >>> Date: Fri May 25 21:46:07 2018 >>> New Revision: 334226 >>> URL: https://svnweb.freebsd.org/changeset/base/334226 >>>=20 >>> Log: >>> Cleanup style >>>=20 >>> Modified: >>> head/lib/libpmcstat/pmu-events/Makefile >>>=20 >>> Modified: head/lib/libpmcstat/pmu-events/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >>> --- head/lib/libpmcstat/pmu-events/Makefile Fri May 25 20:42:28 2018= (r334225) >>> +++ head/lib/libpmcstat/pmu-events/Makefile Fri May 25 21:46:07 2018= (r334226) >>> @@ -1,9 +1,10 @@ >>> # $FreeBSD$ >>>=20 >>> -PROG=3Djevents >>> -SRCS=3Djevents.c jsmn.c json.c >>> +PROG=3D jevents >>> +SRCS=3D jevents.c jsmn.c json.c >>> CFLAGS+=3D -Wno-cast-qual >>> -.PATH: ${.CURDIR} >>> -build-tools: jevents >>> MAN=3D >>> + >>> +build-tools: jevents >>> + >>> .include >>>=20 >>=20 >> Hi Bryan, >>=20 >> Something about this appears to be subtly wrong, but I can't quite pin >> down what. I'm getting a failure in the lib32 build of libpmc: >>=20 >> sh: ./pmu-events/jevents: not found >>=20 >> My observations are that ${OBJDIR}/lib/libpmc/pmu-events/jevents >> exists, as does ${SRCTOP}/lib/libpmc/pmu-events/jevents. >> ${OBJDIR}/obj-lib32/lib/libpmc, OTOH, only contains _INCSINS.meta and >> libpmc_events.c.meta. I'm guessing this is the problem- that >> obj-lib32/... doesn't have the built jevents, but it's not obvious to >> me why this is the case. >=20 > Some additional context: >=20 > SRCCONF is defined to a file that looks like this: >=20 > WITH_BSD_GREP=3D"YES" > WITHOUT_BSD_GREP_FASTMATCH=3D"YES" > WITH_LOADER_LUA=3D"YES" > WITHOUT_FORTH=3D"YES" >=20 > _SRC_ENV_CONF and __MAKE_CONF are set to /dev/null; all three set in > arguments to make(1). OBJDIR has been completely wiped before-hand.