From owner-freebsd-hackers Tue Nov 6 21:48:31 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from db-cvad-1-tmp.yahoo.com (db-cvad-1-tmp.yahoo.com [216.145.48.242]) by hub.freebsd.org (Postfix) with ESMTP id 11F3537B405 for ; Tue, 6 Nov 2001 21:48:29 -0800 (PST) Received: from master.gorean.org (root@master.gorean.org [10.0.0.2]) by db-cvad-1-tmp.yahoo.com (8.11.6/8.11.6) with ESMTP id fA75mSw27964; Tue, 6 Nov 2001 21:48:28 -0800 (PST) (envelope-from DougB@FreeBSD.org) Received: from localhost (doug@localhost) by master.gorean.org (8.11.6/8.11.6) with ESMTP id fA75mPw01120; Tue, 6 Nov 2001 21:48:27 -0800 (PST) (envelope-from DougB@FreeBSD.org) X-Authentication-Warning: master.gorean.org: doug owned process doing -bs Date: Tue, 6 Nov 2001 21:48:25 -0800 (PST) From: Doug Barton X-X-Sender: doug@master.gorean.org To: Arjan de Vet Cc: Darren Reed , Subject: Re: PATCH for review: ipfilter changes in rc.* In-Reply-To: <20011104100641.A79824@adv.devet.org> Message-ID: <20011106213956.O1061-100000@master.gorean.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 4 Nov 2001, Arjan de Vet wrote: > Darren Reed wrote: > > >> >That sounds like a good plan. > >> > >> OK, updated patches for stable and current are available from: > >> > >> http://home.iae.nl/users/devet/freebsd/ > >> > >> I include the README here: > >[...] > > > >How is this progressing ? > > Doug Barton asked whether he could review the patches first but I haven't > heard anything yet. Actually, I asked you to mail them to me. I don't get to read freebsd mail every day. The two suggestion I have off the top are to convert everything of the form: if [ blah -eq blah ]; then to a case statement (as the rest of the file is done) and to take a look at the way I handled the nfs server/client dependencies. It would be preferable (in my opinion) to test for the sysctl. We've somewhat standardized on that method. If you could make those changes and send me a revised patch by mail, I'll get to it asap. I have some time this week. Doug -- "We will not tire, we will not falter, and we will not fail." - George W. Bush, President of the United States September 20, 2001 Do YOU Yahoo!? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message