From owner-p4-projects@FreeBSD.ORG  Sat Dec  6 17:32:19 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 97D591065672; Sat,  6 Dec 2008 17:32:19 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5C27D1065676
	for <perforce@freebsd.org>; Sat,  6 Dec 2008 17:32:19 +0000 (UTC)
	(envelope-from zec@icir.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 4A9098FC14
	for <perforce@freebsd.org>; Sat,  6 Dec 2008 17:32:19 +0000 (UTC)
	(envelope-from zec@icir.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mB6HWJmY040349
	for <perforce@freebsd.org>; Sat, 6 Dec 2008 17:32:19 GMT
	(envelope-from zec@icir.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mB6HWJB6040347
	for perforce@freebsd.org; Sat, 6 Dec 2008 17:32:19 GMT
	(envelope-from zec@icir.org)
Date: Sat, 6 Dec 2008 17:32:19 GMT
Message-Id: <200812061732.mB6HWJB6040347@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zec@icir.org using -f
From: Marko Zec <zec@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 154200 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Dec 2008 17:32:19 -0000

http://perforce.freebsd.org/chv.cgi?CH=154200

Change 154200 by zec@zec_tpx32 on 2008/12/06 17:31:48

	Make options VIMAGE builds actually work by unbreaking
	handlers for virtualized sysctls.

Affected files ...

.. //depot/projects/vimage/src/sys/kern/kern_sysctl.c#15 edit
.. //depot/projects/vimage/src/sys/netinet/in_pcb.c#45 edit
.. //depot/projects/vimage/src/sys/sys/sysctl.h#29 edit

Differences ...

==== //depot/projects/vimage/src/sys/kern/kern_sysctl.c#15 (text+ko) ====

@@ -881,7 +881,9 @@
 {
 	int error, s, tt;
 
-	tt = *(int *)oidp->oid_arg1;
+	SYSCTL_RESOLVE_V_ARG1();
+
+	tt = *(int *)arg1;
 	s = (int)((int64_t)tt * 1000 / hz);
 
 	error = sysctl_handle_int(oidp, &s, 0, req);
@@ -892,7 +894,7 @@
 	if (tt < 1)
 		return (EINVAL);
 
-	*(int *)oidp->oid_arg1 = tt;
+	*(int *)arg1 = tt;
 	return (0);
 }
 

==== //depot/projects/vimage/src/sys/netinet/in_pcb.c#45 (text+ko) ====

@@ -125,7 +125,9 @@
 	INIT_VNET_INET(curvnet);
 	int error;
 
-	error = sysctl_handle_int(oidp, oidp->oid_arg1, oidp->oid_arg2, req);
+	SYSCTL_RESOLVE_V_ARG1();
+
+	error = sysctl_handle_int(oidp, arg1, arg2, req);
 	if (error == 0) {
 		RANGECHK(V_ipport_lowfirstauto, 1, IPPORT_RESERVED - 1);
 		RANGECHK(V_ipport_lowlastauto, 1, IPPORT_RESERVED - 1);

==== //depot/projects/vimage/src/sys/sys/sysctl.h#29 (text+ko) ====

@@ -415,21 +415,28 @@
 #define	SYSCTL_RESOLVE_V_ARG1() do {					\
 	char *cp;							\
 	switch (oidp->oid_v_subs) {					\
+	case V_GLOBAL:							\
+		/* do nothing - this is NOT a virtualized variable! */	\
+		break;							\
 	case V_NET:							\
 		cp = (char *)						\
 		    TD_TO_VNET(curthread)->mod_data[oidp->oid_v_mod];	\
+		arg1 = cp + (size_t) arg1;				\
 		break;							\
 	case V_PROCG:							\
 		cp = (char *) TD_TO_VPROCG(curthread);			\
+		arg1 = cp + (size_t) arg1;				\
 		break;							\
 	case V_CPU:							\
 		cp = (char *) TD_TO_VCPU(curthread);			\
+		arg1 = cp + (size_t) arg1;				\
 		break;							\
 	default:							\
 		panic("unsupported module id %d", oidp->oid_v_subs);	\
 	}								\
-	arg1 = cp + (size_t) arg1;					\
 } while (0)
+#else
+#define SYSCTL_RESOLVE_V_ARG1()
 #endif
 
 #endif /* _KERNEL */