From owner-freebsd-hackers@FreeBSD.ORG  Thu Aug 19 20:18:17 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D0A2F16A4CE
	for <hackers@freebsd.org>; Thu, 19 Aug 2004 20:18:17 +0000 (GMT)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3D7A943D2F
	for <hackers@freebsd.org>; Thu, 19 Aug 2004 20:18:17 +0000 (GMT)
	(envelope-from andre@freebsd.org)
Received: (qmail 759 invoked from network); 19 Aug 2004 20:18:19 -0000
Received: from dotat.atdotat.at (HELO [62.48.0.47]) ([62.48.0.47])
          (envelope-sender <andre@freebsd.org>)
          by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
          for <tedu@coverity.com>; 19 Aug 2004 20:18:19 -0000
Message-ID: <41250B09.6070006@freebsd.org>
Date: Thu, 19 Aug 2004 22:18:17 +0200
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.8a1) Gecko/20040520
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ted Unangst <tedu@coverity.com>
References: <4123049E.9000900@coverity.com>
In-Reply-To: <4123049E.9000900@coverity.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: hackers@freebsd.org
Subject: Re: too late null checks
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Aug 2004 20:18:18 -0000

Ted Unangst wrote:
> Bugs found with Coverity's automated analysis.  In each case, either the 
> NULL check is unnecessary, or it's too late because the variable was 
> already deref'd.
...
> netinet/tcp_subr.c:tcp_mtudisc
> tp has already been dereferenced to obtain isipv6 result

Thanks, fixed.

Did you run your entire tool on the FreeBSD tree or is this subset of the
available tests and checks?

-- 
Andre