From owner-cvs-all@FreeBSD.ORG Tue Feb 15 18:37:55 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4ED616A4CE; Tue, 15 Feb 2005 18:37:55 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5062243D2F; Tue, 15 Feb 2005 18:37:53 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j1FIbjA3022635; Tue, 15 Feb 2005 20:37:45 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 64215-08; Tue, 15 Feb 2005 20:37:45 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j1FIbi14022625 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Feb 2005 20:37:45 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id j1FIbnuO017601; Tue, 15 Feb 2005 20:37:49 +0200 (EET) (envelope-from ru) Date: Tue, 15 Feb 2005 20:37:44 +0200 From: Ruslan Ermilov To: Sam Leffler Message-ID: <20050215183744.GA17554@ip.net.ua> References: <200502140829.j1E8TgDs086634@repoman.freebsd.org> <4210D210.3080700@errno.com> <20050214181431.GA69635@ip.net.ua> <4210F849.8060005@errno.com> <20050214195558.GD69635@ip.net.ua> <421104C7.4070709@errno.com> <20050215074226.GA6781@ip.net.ua> <42123604.9070002@errno.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <42123604.9070002@errno.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2005 18:37:56 -0000 --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 15, 2005 at 09:48:52AM -0800, Sam Leffler wrote: > If the intent is simply to eliminate the dispatch of frames out of the=20 > driver when there are no vlan consumers then it would seem another=20 > option is to do this at the source. I suggested this initially--that=20 > VLAN_INPUT_TAG be augmented to discard frames when if_nvlans is zero=20 > (this would also eliminate gratuitous tag allocation). I believe you're= =20 > saying that if_nvlans can be zero and there may still be consumers for=20 > the packets in which case we might look at a better way of indicating=20 > there are consumers for the packets assuming we can be sure they won't=20 > reach ether_demux (which might be hard). >=20 Yes, this can be hard -- consumers may live on another machine, read: there's no direct link to the underlying hardware that supplies VLAN frames. > As to your other suggestion of allocating an mbuf flag bit that'd be=20 > fine with me. I didn't offer that because I thought we were out of free= =20 > bits but I see m_flags got changed to an int a while back and only=20 > 16-bits are assigned. >=20 OK, I'll post the patches soon then. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFCEkF4qRfpzJluFF4RArqIAJsFdc8nE+20z7MuDW1Vaco49eJwZQCffWbK Fx1uwYcwp2XThMU8eOb2gG8= =F78p -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--