From owner-freebsd-virtualization@FreeBSD.ORG  Fri Apr  9 19:07:43 2010
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1BA9F1065678;
	Fri,  9 Apr 2010 19:07:43 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
	by mx1.freebsd.org (Postfix) with ESMTP id D3B588FC15;
	Fri,  9 Apr 2010 19:07:42 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id 1121673098; Fri,  9 Apr 2010 20:58:45 +0200 (CEST)
Date: Fri, 9 Apr 2010 20:58:45 +0200
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Julian Elischer <julian@elischer.org>
Message-ID: <20100409185845.GA56240@onelab2.iet.unipi.it>
References: <4BBCE3EE.506@halleforshunden.org>
	<20100407203802.GA91356@onelab2.iet.unipi.it>
	<4BBCF17F.4000408@elischer.org>
	<20100409141722.GA53191@onelab2.iet.unipi.it>
	<4BBF7387.5010604@elischer.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BBF7387.5010604@elischer.org>
User-Agent: Mutt/1.4.2.3i
X-Mailman-Approved-At: Fri, 09 Apr 2010 22:58:01 +0000
Cc: virtualization@freebsd.org, anchie@freebsd.org,
	Anders Hagman <anders.hagman@halleforshunden.org>
Subject: Re: dummynet and vnet kernel panic
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2010 19:07:43 -0000

On Fri, Apr 09, 2010 at 11:35:51AM -0700, Julian Elischer wrote:
> On 4/9/10 7:17 AM, Luigi Rizzo wrote:
...
> >former global variables are now mostly in a single struct, dn_cfg.
> >There are however 150 lines where the global variable is used, so
> >I am bit scared at renaming all of these occurrences from dn_cfg
> >to V_dn_cfg. I'd rather follow a different approach, i.e
> 
> it woudl work but we avoided that way because we specifically wantet 
> to be able to see at a glance whether virtualization is involved 
> somewhere.  The change of name is just a single vi command..

Yes but the V_visual effect is V_horrible!
Besides, all per-vimage state will be in a single variable, it will
be easy for the programmer to know which is which.

cheers
luigi