From owner-cvs-src@FreeBSD.ORG Mon Mar 22 08:04:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C38716A4CE; Mon, 22 Mar 2004 08:04:44 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 355BE43D31; Mon, 22 Mar 2004 08:04:44 -0800 (PST) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i2MG4hGe084227; Mon, 22 Mar 2004 08:04:43 -0800 (PST) (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i2MG4ht3084226; Mon, 22 Mar 2004 08:04:43 -0800 (PST) (envelope-from rwatson) Message-Id: <200403221604.i2MG4ht3084226@repoman.freebsd.org> From: Robert Watson Date: Mon, 22 Mar 2004 08:04:43 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_gre.c if_gre.h src/sys/netinet ip_gre.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2004 16:04:44 -0000 rwatson 2004/03/22 08:04:43 PST FreeBSD src repository Modified files: sys/net if_gre.c if_gre.h sys/netinet ip_gre.c Log: Lock down global variables in if_gre: - Add gre_mtx to protect global softc list. - Hold gre_mtx over various list operations (insert, delete). - Centralize if_gre interface teardown in gre_destroy(), and call this from modevent unload and gre_clone_destroy(). - Export gre_mtx to ip_gre.c, which walks the gre list to look up gre interfaces during encapsulation. Add a wonking comment on how we need some sort of drain/reference count mechanism to keep gre references alive while in use and simultaneous destroy. This commit does not lockdown softc data, which follows in a future commit. Revision Changes Path 1.21 +33 -8 src/sys/net/if_gre.c 1.11 +1 -0 src/sys/net/if_gre.h 1.16 +12 -1 src/sys/netinet/ip_gre.c