From owner-freebsd-bugs Thu Dec 7 16:40:34 1995 Return-Path: owner-bugs Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id QAA07162 for bugs-outgoing; Thu, 7 Dec 1995 16:40:34 -0800 (PST) Received: from linus.demon.co.uk (linus.demon.co.uk [158.152.10.220]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id QAA07098 Thu, 7 Dec 1995 16:40:15 -0800 (PST) Received: (from mark@localhost) by linus.demon.co.uk (8.7.3/8.7.3) id AAA01455; Fri, 8 Dec 1995 00:37:37 GMT Message-Id: <199512080037.AAA01455@linus.demon.co.uk> From: mark@linus.demon.co.uk (Mark Valentine) Date: Fri, 8 Dec 1995 00:37:36 +0000 In-Reply-To: Poul-Henning Kamp's message of Dec 1, 3:16am X-Mailer: Mail User's Shell (7.2.6 alpha(2) 7/9/95) To: Poul-Henning Kamp , joerg_wunsch@uriah.heep.sax.de, freebsd-bugs@freefall.freebsd.org Subject: Re: gnu/231 Sender: owner-bugs@FreeBSD.ORG Precedence: bulk > From: Poul-Henning Kamp > Date: Fri 1 Dec, 1995 > Subject: Re: gnu/231 > Synopsis: send-pr initializes Organization with ~/.signature > > State-Changed-From-To: open-closed > State-Changed-By: phk > State-Changed-When: Fri Dec 1 03:16:04 PST 1995 > State-Changed-Why: > Nobody has any better idea, so it may not be right, but it is the best > we can do. Hmm. I just got bit by this when I gave myself a .signature. Before that, send-pr correctly used $ORGANIZATION_C='' to remind me to either fill it in or delete the line (I don't have an organisation - I already had to hack trn not to fail because of that!). It is incorrect to use random junk from .signature for this. Just delete the two lines in question and send-pr does more or less the right thing. However, send-pr doesn't do the rest using quite the algorithm I know from other programs either. How about something like: 1. If $ORGANIZATION is set, use it. 1a. Otherwise, if $ORGANISATION is set, use it. 2. If neither variable is set, and $DEFAULT_ORGANIZATION has been configured in send-pr.sh, use that. 3. In any case, if the value of any of these variables starts with / or ~, treat it as a file and use the contents of that file. (For those who setenv ORGANIZATION ~/.organisation.) 4. If none of these variables are set, and ~/.organization or ~/.organisation exists, use its contents. (Note: don't do this if either $ORGANIZATION or $ORGANISATION was found and was set empty, but do if $DEFAULT_ORGANIZATION is set empty.) 5. Otherwise, let the later code fall back to $ORGANIZATION_C. Other variations are acceptable, such as ignoring the correctly spelled alternatives [some Canadian news transport authors would support me here, though ;-) ], or using application-specific variables or files (equivalents to $NEWSORGANIZATION? and /usr/lib/news/organization at the appropriate points). The ~/.organization probably isn't "standard" (it's redundant anyway). (DEFAULT_ORGANIZATION=/etc/organization is a good idea for some sites.) Mark (whose organisation, if it existed, probably wouldn't have anything to do with tigers or tuna fish). -- "Tigers will do ANYTHING for a tuna fish sandwich." "We're kind of stupid that way." *munch* *munch*