From owner-freebsd-current@FreeBSD.ORG  Sat Aug 15 08:26:45 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 57142106568B
	for <freebsd-current@FreeBSD.org>; Sat, 15 Aug 2009 08:26:45 +0000 (UTC)
	(envelope-from randy@psg.com)
Received: from ran.psg.com (ran.psg.com [IPv6:2001:418:1::36])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B8DC8FC55
	for <freebsd-current@FreeBSD.org>; Sat, 15 Aug 2009 08:26:45 +0000 (UTC)
Received: from localhost ([127.0.0.1] helo=rmac.psg.com)
	by ran.psg.com with esmtp (Exim 4.69 (FreeBSD))
	(envelope-from <randy@psg.com>)
	id 1McEb3-000MCO-Bm; Sat, 15 Aug 2009 08:26:41 +0000
Received: from rmac.local.psg.com (localhost [127.0.0.1])
	by rmac.psg.com (Postfix) with ESMTP id 29A192951DD6;
	Sat, 15 Aug 2009 17:26:41 +0900 (JST)
Date: Sat, 15 Aug 2009 17:26:41 +0900
Message-ID: <m2eird1nzy.wl%randy@psg.com>
From: Randy Bush <randy@psg.com>
To: Dmitry Marakasov <amdmi3@amdmi3.ru>
In-Reply-To: <20090814005324.GA1552@hades.panopticon>
References: <20090801022523.GA93222@hades.panopticon>
	<4A84A901.4010109@elischer.org>
	<20090814005324.GA1552@hades.panopticon>
User-Agent: Wanderlust/2.15.5 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: freebsd-current@FreeBSD.org, Julian Elischer <julian@elischer.org>
Subject: Re: panic in ipfw with recent current
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Aug 2009 08:26:45 -0000

>> in line 2061 of ip_fw2.c in the crhold()
>> the argument should be pcb->inp_cred, not inp->cred
>> 
>> 2059        if (pcb != NULL) {
>> 2060              *uc = crhold(inp->inp_cred); <--s/inp/pcb/
>> 2061              *ugid_lookupp = 1;
>> 2062        }
> 
> Confirmed, this fixes the problem. Filtering by gid works and no
> panics. Thanks a lot!

also confirmed.  <whew!>

randy