From owner-freebsd-current Fri Oct 25 13:46:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AF4C37B404 for ; Fri, 25 Oct 2002 13:46:38 -0700 (PDT) Received: from albatross.prod.itd.earthlink.net (albatross.mail.pas.earthlink.net [207.217.120.120]) by mx1.FreeBSD.org (Postfix) with ESMTP id B46BA43E6A for ; Fri, 25 Oct 2002 13:46:37 -0700 (PDT) (envelope-from tlambert2@mindspring.com) Received: from pool0348.cvx22-bradley.dialup.earthlink.net ([209.179.199.93] helo=mindspring.com) by albatross.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 185BKQ-0005Tg-00; Fri, 25 Oct 2002 13:45:10 -0700 Message-ID: <3DB9AD0D.E1C553D7@mindspring.com> Date: Fri, 25 Oct 2002 13:43:57 -0700 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Brooks Davis Cc: Bakul Shah , Dave Evans , freebsd-current@FreeBSD.ORG Subject: Re: pppd not working on latest current 2002-10-20 References: <20021025113137.A23521@Odin.AC.HMC.Edu> <200210251841.OAA09782@valiant.cnchost.com> <20021025123522.B23521@Odin.AC.HMC.Edu> <3DB9A281.6FE378F5@mindspring.com> <20021025130909.B7985@Odin.AC.HMC.Edu> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Brooks Davis wrote: > > > If someone who actually uses pppd could test it, perferably in both > > > sceneios, I'll see about getting it commited. > > > > Try running you program when the module is there, but fails to load. > > You got rid of the failure message that it used to print. > > No, it just let the default one be printed instead. The one in the > function was just plain wrong and the default one is reasonable: > > Sorry - this system lacks PPP kernel support > > You either had to know what you were doing or cluelessly fail to follow > the exceptionaly simple instructions to build and install a > kernel+modules to get to that point, so a long winded message explaning > how to correct the problem isn't likely to be useful. I suppose a > better message could be written, but I didn't see a point. It's a moderately common case in -CURRENT, when kernel structure sizes change, and you build a new kernel without new modules, and a module refuses to load. It's not technically correct. The old message might not be either, but at least it had you looking in the right place. The whole area is pretty messy, unfortunately. 8-(. Your patch is a definite improvement, though the lack of a message makes the failure case harder to diagnose, unless you happen to know that it only happens when the module fails to load. Anyway, it's at least improvement enough to stop people who have a matching ppp module, but forgot to load it, from complaining. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message