From owner-svn-ports-all@FreeBSD.ORG Tue May 19 21:53:54 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F7673FE; Tue, 19 May 2015 21:53:54 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C67A11B6D; Tue, 19 May 2015 21:53:53 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id E073ABDC24; Tue, 19 May 2015 23:53:51 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id BD76EBDC1F; Tue, 19 May 2015 23:53:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id 52BE135D3952; Tue, 19 May 2015 23:53:51 +0200 (CEST) Date: Tue, 19 May 2015 23:53:51 +0200 From: Mathieu Arnold To: Adam Weinberger cc: Baptiste Daroussin , "Vanilla I. Shu" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r386737 - in head/security: . tmux-cssh Message-ID: In-Reply-To: References: <201505190333.t4J3X7BS037914@svn.freebsd.org> <20150519160457.GD52236@ivaldir.etoilebsd.net> <38D41B521FF4590990C78FD2@atuin.in.mat.cc> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 21:53:54 -0000 +--On 19 mai 2015 15:23:54 -0600 Adam Weinberger wrote: |> On 19 May, 2015, at 15:15, Mathieu Arnold wrote: |> |> |> |> +--On 19 mai 2015 10:15:36 -0600 Adam Weinberger wrote: |> |> On 19 May, 2015, at 10:04, Baptiste Daroussin |> |> wrote: |> |> |> |> On Tue, May 19, 2015 at 03:33:07AM +0000, Vanilla I. Shu wrote: |> |>> Author: vanilla |> |>> Date: Tue May 19 03:33:06 2015 |> |>> New Revision: 386737 |> |>> URL: https://svnweb.freebsd.org/changeset/ports/386737 |> |>> |> |>> |> |>> +RUN_DEPENDS= ${LOCALBASE}/bin/tmux:${PORTSDIR}/sysutils/tmux |> |> The dependency is wrong it should be tmux:${PORTSDIR}/sysutils/tmux |> |> |> |> Best regards, |> |> Bapt |> | |> | I've seen that construct popping up a lot lately. I suspect that the |> | problem is that |> | https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/mak |> | efi le-depend.html lists ${LOCALBASE}/.../ as the first example. |> | |> | Perhaps it would be helpful to add something saying "Only include an |> | absolute path if the binary is outside of $PATH, or if the binary also |> | exists in base and you specifically want the ports tree version." |> |> There's a note afterwards saying it, but you're right, there should be an |> example with only a binary in the path first. | | It says to use full path when it's not in $PATH. What it doesn't say is | to use full path ONLY when it's not in $PATH :-) Yes, yes, I get it, I'll change the example so that the one using a full path is *not* an executable :-) -- Mathieu Arnold