From owner-svn-src-all@FreeBSD.ORG  Fri Mar 13 21:44:34 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 46221D9;
 Fri, 13 Mar 2015 21:44:34 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1ED80C0E;
 Fri, 13 Mar 2015 21:44:34 +0000 (UTC)
Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net
 [173.54.116.245])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 276A5B9A6;
 Fri, 13 Mar 2015 17:44:32 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Alexander Motin <mav@freebsd.org>
Subject: Re: svn commit: r279965 - head/usr.sbin/bhyve
Date: Fri, 13 Mar 2015 17:04:32 -0400
Message-ID: <2486513.R1ROTfJbIk@ralph.baldwin.cx>
User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; )
In-Reply-To: <201503132014.t2DKEZY3084111@svn.freebsd.org>
References: <201503132014.t2DKEZY3084111@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 13 Mar 2015 17:44:32 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2015 21:44:34 -0000

On Friday, March 13, 2015 08:14:35 PM Alexander Motin wrote:
> Author: mav
> Date: Fri Mar 13 20:14:35 2015
> New Revision: 279965
> URL: https://svnweb.freebsd.org/changeset/base/279965
> 
> Log:
>   Polish AHCI disk identify data and fix speed negotiation.
>   
>   MFC after:	2 weeks
> 
> Modified:
>   head/usr.sbin/bhyve/ahci.h
>   head/usr.sbin/bhyve/pci_ahci.c
> 
> Modified: head/usr.sbin/bhyve/ahci.h
> ==============================================================================
> --- head/usr.sbin/bhyve/ahci.h	Fri Mar 13 20:10:09 2015	(r279964)
> +++ head/usr.sbin/bhyve/ahci.h	Fri Mar 13 20:14:35 2015	(r279965)
> @@ -96,13 +96,14 @@
>  #define         ATA_SS_SPD_NO_SPEED     0x00000000
>  #define         ATA_SS_SPD_GEN1         0x00000010
>  #define         ATA_SS_SPD_GEN2         0x00000020
> -#define         ATA_SS_SPD_GEN3         0x00000040
> +#define         ATA_SS_SPD_GEN3         0x00000030
>  
>  #define         ATA_SS_IPM_MASK         0x00000f00
>  #define         ATA_SS_IPM_NO_DEVICE    0x00000000
>  #define         ATA_SS_IPM_ACTIVE       0x00000100
>  #define         ATA_SS_IPM_PARTIAL      0x00000200
>  #define         ATA_SS_IPM_SLUMBER      0x00000600
> +#define         ATA_SS_IPM_DEVSLEEP     0x00000800

I wonder if it would make sense to have a shared header for these constants (given that
it seems they are copied in 4 other places for in-kernel drivers)?

-- 
John Baldwin