From owner-svn-src-all@freebsd.org Sat Sep 9 19:07:31 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A93CBE030AF for ; Sat, 9 Sep 2017 19:07:31 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from bat.oak.relay.mailchannels.net (bat.oak.relay.mailchannels.net [23.83.215.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 64F30741CB for ; Sat, 9 Sep 2017 19:07:31 +0000 (UTC) (envelope-from ian@freebsd.org) X-Sender-Id: _forwarded-from|73.78.92.27 Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DF5AB8A8D2C for ; Sat, 9 Sep 2017 19:07:23 +0000 (UTC) Received: from outbound1a.eu.mailhop.org (unknown [100.96.129.235]) (Authenticated sender: duocircle) by relay.mailchannels.net (Postfix) with ESMTPA id 46F768A8D2F for ; Sat, 9 Sep 2017 19:07:23 +0000 (UTC) X-Sender-Id: _forwarded-from|73.78.92.27 Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [172.20.52.122]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.9.14); Sat, 09 Sep 2017 19:07:23 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: _forwarded-from|73.78.92.27 X-MailChannels-Auth-Id: duocircle X-Tart-Cure: 5f1a78a765919590_1504984043715_988452242 X-MC-Loop-Signature: 1504984043715:1089999642 X-MC-Ingress-Time: 1504984043715 X-MHO-User: 1926c2ac-9592-11e7-83af-a91f44540cb3 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 1926c2ac-9592-11e7-83af-a91f44540cb3; Sat, 09 Sep 2017 19:07:19 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v89J7FEh004368; Sat, 9 Sep 2017 13:07:15 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1504984035.32063.61.camel@freebsd.org> Subject: Re: svn commit: r323359 - in head/sys: conf dev/uart modules/uart From: Ian Lepore To: Sean Bruno , Marcin Wojtas , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 09 Sep 2017 13:07:15 -0600 In-Reply-To: <2ace05fc-4dc9-494a-8e6f-27fa9f1ebf97@freebsd.org> References: <201709091142.v89BgX8e090592@repo.freebsd.org> <1504981201.32063.59.camel@freebsd.org> <2ace05fc-4dc9-494a-8e6f-27fa9f1ebf97@freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Sep 2017 19:07:31 -0000 On Sat, 2017-09-09 at 12:45 -0600, Sean Bruno wrote: >=20 > On 09/09/17 12:20, Ian Lepore wrote: > >=20 > > On Sat, 2017-09-09 at 12:09 -0600, Sean Bruno wrote: > > >=20 > > >=20 > > > On 09/09/17 05:42, Marcin Wojtas wrote: > > > >=20 > > > >=20 > > > > Author: mw > > > > Date: Sat Sep=A0=A09 11:42:32 2017 > > > > New Revision: 323359 > > > > URL: https://svnweb.freebsd.org/changeset/base/323359 > > > >=20 > > > > Log: > > > > =A0 Introduce UART driver module for Armada 3700 > > > > =A0=A0 > > > > =A0 This patch adds support for UART in Armada 3700 family. > > > > =A0 It exposes both low-level UART interface, as well as > > > > =A0 standard driver methods. > > > > =A0=A0 > > > > =A0 Submitted by: Patryk Duda > > > > =A0 Obtained from: Semihalf > > > > =A0 Sponsored by: Semihalf > > > > =A0 Differential Revision: https://reviews.freebsd.org/D12250 > > > >=20 > > > > Added: > > > > =A0 head/sys/dev/uart/uart_dev_mvebu.c=A0=A0=A0(contents, props > > > > changed) > > > > Modified: > > > > =A0 head/sys/conf/files > > > > =A0 head/sys/modules/uart/Makefile > > > Hrm ... I seem to be getting a compile failure after this: > > >=20 > > > cc -target x86_64-unknown-freebsd12.0 -- > > > sysroot=3D/var/tmp/usr/src/tmp > > > -B/var/tmp/usr/src/tmp/usr/bin=A0=A0-O2 -pipe=A0=A0-fno-strict-alia= sing > > > -Werror > > > -D_KERNEL -DKLD_MODULE -nostdinc=A0=A0=A0-DHAVE_KERNEL_OPTION_HEADE= RS > > > -include > > > /var/tmp/usr/src/sys/GENERIC-NODEBUG/opt_global.h -I. > > > -I/usr/src/sys > > > -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame- > > > pointer > > > -I/var/tmp/usr/src/sys/GENERIC-NODEBUG=A0=A0=A0-MD > > > -MF.depend.uart_dev_mvebu.o -MTuart_dev_mvebu.o -mcmodel=3Dkernel > > > -mno-red-zone -mno-mmx -mno-sse -msoft-float > > > -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack- > > > protector > > > -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict- > > > prototypes > > > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > > > -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ > > > -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown- > > > pragmas > > > -Wno-error-tautological-compare -Wno-error-empty-body > > > -Wno-error-parentheses-equality -Wno-error-unused-function > > > -Wno-error-pointer-sign -Wno-error-shift-negative-value > > > -Wno-error-address-of-packed-member=A0=A0-mno-aes -mno-avx > > > -std=3Diso9899:1999 -c /usr/src/sys/dev/uart/uart_dev_mvebu.c -o > > > uart_dev_mvebu.o > > > In file included from /usr/src/sys/dev/uart/uart_dev_mvebu.c:39: > > > /usr/src/sys/dev/ofw/ofw_bus_subr.h:40:10: fatal error: > > > 'ofw_bus_if.h' > > > file not found > > > #include "ofw_bus_if.h" > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0^~~~~~~~~~~~~~ > > > 1 error generated. > > > *** Error code 1 > > >=20 > > > Is there supposed to be processing of ofw_bus_if.m somewhere that > > > is > > > currently missed? > > >=20 > > > sean > > >=20 > > ofw_bus_if.h needs to be added to SRCS=3D in the module > > makefile.=A0=A0Over > > the years I learned to grep the c files for _if.h to figure out > > what > > generated files to add to a module makefile, but ofw_bus_if.h is > > insidious -- it gets included from ofw_bus_subr.h so nobody > > includes it > > directly and it always gets missed in new module makefiles. > >=20 > > -- Ian > >=20 > >=20 > >=20 >=20 > Oh, the SRCS entry *is* in sys/modules/uart/Makefile but not for x86 > archs.=A0=A0Should this even be built for x86? >=20 > sean >=20 No, this driver is specific to Marvell arm systems. =A0Mostly, arm uart drivers don't get listed in modules/uart becuase they're compiled in as console drivers. =A0A few arm systems have video consoles and uart as a module might have more value. -- Ian